From: Arjan van de Ven <arjan@infradead.org>
To: ecashin@noserose.net
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Greg K-H <greg@kroah.com>,
axboe@suse.de
Subject: Re: [PATCH 2.6.11] aoe [5/12]: don't try to free null bufpool
Date: Thu, 24 Mar 2005 18:17:06 +0100 [thread overview]
Message-ID: <1111684626.6290.103.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1111683853.31205@geode.he.net>
On Thu, 2005-03-24 at 09:04 -0800, ecashin@noserose.net wrote:
> Arjan van de Ven <arjan@infradead.org> writes:
>
> > On Thu, 2005-03-24 at 07:17 -0800, ecashin@noserose.net wrote:
> >> don't try to free null bufpool
> >
> > in linux there is a "rule" that all memory free routines are supposed to
> > also accept NULL as argument, so I think this patch is not needed (and
> > even wrong)
> >
>
> Hmm. The mm/mempool.c:mempool_destroy function immediately
> dereferences the pointer passed to it:
>
> void mempool_destroy(mempool_t *pool)
> {
> if (pool->curr_nr != pool->min_nr)
> BUG(); /* There were outstanding elements */
> free_pool(pool);
> }
>
> ... so I'm not sure mempool_destroy fits the rule. Are you suggesting
> that the patch should instead modify mempool_destroy?
hmm perhaps... Jens?
next prev parent reply other threads:[~2005-03-24 17:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87mztbi79d.fsf@coraid.com>
2005-03-17 23:46 ` [PATCH 2.6.11] aoe [1/12]: remove too-low cap on minor number Greg KH
2005-03-18 20:13 ` Ed L Cashin
2005-03-18 20:14 ` [PATCH 2.6.11] aoe [4/12]: handle distros that have a udev rules file instead of dir Ed L. Cashin
2005-03-24 14:59 ` [PATCH 2.6.11] aoe [1/12]: remove too-low cap on minor number ecashin
2005-03-24 15:09 ` [PATCH 2.6.11] aoe [2/12]: allow multiple aoe devices with same MAC addr ecashin
2005-03-24 15:13 ` [PATCH 2.6.11] aoe [3/12]: update driver version to 6 ecashin
2005-03-24 15:15 ` [PATCH 2.6.11] aoe [4/12]: handle distros that have a udev rules file instead of dir ecashin
2005-03-24 15:17 ` [PATCH 2.6.11] aoe [5/12]: don't try to free null bufpool ecashin
2005-03-24 15:58 ` Arjan van de Ven
2005-03-24 17:04 ` ecashin
2005-03-24 17:17 ` Arjan van de Ven [this message]
2005-03-25 14:37 ` Jesper Juhl
2005-03-29 12:31 ` Jens Axboe
2005-03-24 15:19 ` [PATCH 2.6.11] aoe [6/12]: Alexey Dobriyan sparse cleanup ecashin
2005-03-24 15:21 ` [PATCH 2.6.11] aoe [7/12]: support configuration of AOE_PARTITIONS from Kconfig ecashin
2005-03-28 17:07 ` Christoph Hellwig
2005-03-29 16:06 ` Ed L Cashin
2005-03-29 16:25 ` Christoph Hellwig
2005-03-29 16:48 ` Ed L Cashin
2005-03-29 16:57 ` Christoph Hellwig
2005-04-07 18:28 ` Ed L Cashin
2005-04-07 18:49 ` Greg KH
2005-04-07 18:56 ` Ed L Cashin
2005-04-07 23:08 ` Greg KH
2005-04-08 13:54 ` Ed L Cashin
2005-03-24 15:23 ` [PATCH 2.6.11] aoe [8/12]: document env var for specifying number of partitions per dev ecashin
2005-03-24 15:25 ` [PATCH 2.6.11] aoe [9/12]: add note about the need for deadlock-free sk_buff allocation ecashin
2005-03-24 15:27 ` [PATCH 2.6.11] aoe [10/12]: Randy Dunlap: avoid warnings on sparc64 ecashin
2005-03-24 15:30 ` [PATCH 2.6.11] aoe [11/12]: add support for disk statistics ecashin
2005-03-24 15:32 ` [PATCH 2.6.11] aoe [12/12]: send outgoing packets in order ecashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111684626.6290.103.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=axboe@suse.de \
--cc=ecashin@noserose.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®