mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Adrian Bunk <bunk@stusta.de>,
	linux-kernel@vger.kernel.org, linux-msdos@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: 2.6.12-rc1 breaks dosemu
Date: Sat, 26 Mar 2005 09:25:00 +0100	[thread overview]
Message-ID: <1111825501.6293.25.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200503252354.53154.arnd@arndb.de>

On Fri, 2005-03-25 at 23:54 +0100, Arnd Bergmann wrote:
> On Freedag 25 März 2005 20:14, Arjan van de Ven wrote:
> 
> > the randomisation patches came in a series of 8 patches (where several
> > were general infrastructure); could you try to disable the individual
> > randomisations one at a time to see which one causes this effect?
> 
> It's caused by top-of-stack-randomization.patch.
> 

looking at the dosemu code; the following bit looks a tad suspect:

unsigned long int stk_ptr, stk_beg, stk_end;
...
 if ((fp = fopen("/proc/self/maps", "r"))) {
    while(fgets(line, 100, fp)) {
      sscanf(line, "%lx-%lx", &stk_beg, &stk_end);
      if (stk_ptr >= stk_beg && stk_ptr < stk_end) {
        stack_init_top = stk_end;
        stack_init_bot = stk_beg;
        c_printf("CPU: Stack bottom %#lx, top %#lx, esp=%#lx\n",
	  stack_init_bot, stack_init_top, stk_ptr);
	break;
      }
    }
    fclose(fp);
  }

do you see that printf somewhere in the logs? 
(afaics stk_ptr never gets initialized; what the code meant probably was 
 if (&stk_ptr >= stk_beg && &stk_ptr < stk_end) {
but the dosemu code is missing the two &'s )


  parent reply	other threads:[~2005-03-26  8:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-20  2:11 Adrian Bunk
2005-03-20  3:04 ` Gene Heskett
2005-03-25 18:52 ` Arnd Bergmann
2005-03-25 19:14   ` Arjan van de Ven
2005-03-25 22:54     ` Arnd Bergmann
2005-03-26  8:10       ` Arjan van de Ven
2005-03-26  8:18         ` Bart Oldeman
2005-03-26 13:49           ` Arnd Bergmann
2005-03-26 14:28             ` Arjan van de Ven
2005-03-26 14:35               ` Arjan van de Ven
2005-03-26  8:25       ` Arjan van de Ven [this message]
2005-03-26  8:32         ` Bart Oldeman
2005-03-26  9:28           ` Arjan van de Ven
2005-03-31  6:43             ` Bart Oldeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1111825501.6293.25.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=arnd@arndb.de \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-msdos@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®