mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe Saout <christophe@saout.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@muc.de>, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix preemption off of irq context on x86-64 with PREEMPT_BKL
Date: Sun, 27 Mar 2005 01:19:06 +0100	[thread overview]
Message-ID: <1111882746.32348.6.camel@leto.cs.pocnet.net> (raw)
In-Reply-To: <1111778785.14840.13.camel@leto.cs.pocnet.net>

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

Hi,

> x86_64-fix-config_preempt.patch
>   x86_64: Fix CONFIG_PREEMPT

This patch causes another bug to show up some lines below with
CONFIG_PREEMPT_BKL. schedule releases the BKL which it shouldn't do.

Call preempt_schedule_irq instead (like for i386). This seems to fix the
easily reproducible filesystem errors I've seen (with reiserfs, which
heavily relies on the BKL).

Signed-off-by: Christophe Saout <christophe@saout.de>

--- linux-2.6.12-rc1-mm2.orig/arch/x86_64/kernel/entry.S	2005-03-24 17:32:22.000000000 +0100
+++ linux-2.6.12-rc1-mm2/arch/x86_64/kernel/entry.S	2005-03-26 23:40:30.000000000 +0100
@@ -517,12 +517,7 @@
 	jnc  retint_restore_args
 	bt   $9,EFLAGS-ARGOFFSET(%rsp)	/* interrupts off? */
 	jnc  retint_restore_args
-	movl $PREEMPT_ACTIVE,threadinfo_preempt_count(%rcx)
-	sti
-	call schedule
-	cli
-	GET_THREAD_INFO(%rcx)
-	movl $0,threadinfo_preempt_count(%rcx) 
+	call preempt_schedule_irq
 	jmp exit_intr
 #endif	
 	CFI_ENDPROC


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2005-03-27  0:19 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-24 12:41 2.6.12-rc1-mm2 Andrew Morton
2005-03-24 14:40 ` 2.6.12-rc1-mm2 Stefano Rivoir
2005-03-24 15:13   ` 2.6.12-rc1-mm2 Manuel Lauss
2005-03-24 15:18   ` 2.6.12-rc1-mm2 Brice Goglin
2005-03-24 15:31     ` 2.6.12-rc1-mm2 Stefano Rivoir
2005-03-24 20:05       ` 2.6.12-rc1-mm2 Andrew Morton
2005-03-24 20:21         ` 2.6.12-rc1-mm2 Brice Goglin
2005-03-25  1:19           ` 2.6.12-rc1-mm2 Alexey Dobriyan
2005-03-24 15:09 ` 2.6.12-rc1-mm2 (build error In function `zft_init') Steven Cole
2005-03-24 15:55   ` 2.6.12-rc1-mm2 (patch to fix build " Steven Cole
2005-03-24 21:49     ` Greg KH
2005-03-24 21:53       ` Andrew Morton
2005-03-24 16:46 ` 2.6.12-rc1-mm2 Lee Revell
2005-03-24 20:17   ` 2.6.12-rc1-mm2 Andrew Morton
2005-03-24 22:31     ` 2.6.12-rc1-mm2 Rafael J. Wysocki
2005-03-24 22:37       ` 2.6.12-rc1-mm2 Rafael J. Wysocki
2005-03-24 23:33       ` 2.6.12-rc1-mm2 Laurent Riffard
2005-03-24 23:49         ` 2.6.12-rc1-mm2 Andrew Morton
2005-03-25  1:00           ` 2.6.12-rc1-mm2 Patrick Mochel
2005-03-25  6:05             ` 2.6.12-rc1-mm2 Greg KH
2005-03-25 18:01             ` 2.6.12-rc1-mm2 Laurent Riffard
2005-05-26  0:29       ` 2.6.12-rc1-mm2 Andrew Morton
2005-05-26 13:58         ` 2.6.12-rc1-mm2 Rafael J. Wysocki
2005-03-25  0:38 ` [2.6 patch] remove exports for oem modules Adrian Bunk
2005-03-25  4:12 ` OOPS running "ls -l /sys/class/i2c-adapter/*"-- 2.6.12-rc1-mm2 Miles Lane
2005-03-25  4:22   ` Andrew Morton
2005-03-25  7:38     ` Russell King
2005-03-25  7:45       ` Andrew Morton
2005-03-25  7:50         ` Russell King
2005-03-25  8:13           ` Russell King
2005-03-25 12:52             ` Miles Lane
2005-03-25 18:40               ` Andrew Morton
2005-03-25 19:50                 ` Jean Delvare
2005-03-26  4:44                   ` Miles Lane
2005-03-25 20:53       ` Lee Revell
2005-03-25 21:07         ` Russell King
2005-03-25 21:45           ` [PATCH] make Documentation/oops-tracing.txt relevant to 2.6 [was Re: OOPS running "ls -l /sys/class/i2c-adapter/*"-- 2.6.12-rc1-mm2] Lee Revell
2005-03-25 21:52             ` Russell King
2005-03-25 21:54               ` Lee Revell
2005-03-25 19:26 ` x86-64 preemption fix from IRQ and BKL in 2.6.12-rc1-mm2 Christophe Saout
2005-03-27  0:19   ` Christophe Saout [this message]
2005-03-27 17:28     ` [PATCH] Fix preemption off of irq context on x86-64 with PREEMPT_BKL Andi Kleen
2005-03-27 17:26   ` x86-64 preemption fix from IRQ and BKL in 2.6.12-rc1-mm2 Andi Kleen
2005-03-27 18:05     ` Christophe Saout
2005-03-28 15:26       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1111882746.32348.6.camel@leto.cs.pocnet.net \
    --to=christophe@saout.de \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®