mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	fastboot <fastboot@lists.osdl.org>
Subject: [RFC/PATCH 11/17][Kdump] Routines for copying dump pages fixes
Date: Mon, 28 Mar 2005 18:57:16 +0530	[thread overview]
Message-ID: <1112016436.4001.82.camel@localhost.localdomain> (raw)

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: crashdump-routines-for-copying-dump-pages-fixes.patch --]
[-- Type: text/x-patch, Size: 1233 bytes --]



Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/kernel/crash_dump.c |    5 ++++-
 arch/i386/mm/highmem.c      |    0 
 include/asm-i386/highmem.h  |    0 
 include/linux/highmem.h     |    0 
 4 files changed, 4 insertions(+), 1 deletion(-)

diff -puN arch/i386/mm/highmem.c~crashdump-routines-for-copying-dump-pages-fixes arch/i386/mm/highmem.c
diff -puN include/asm-i386/highmem.h~crashdump-routines-for-copying-dump-pages-fixes include/asm-i386/highmem.h
diff -puN include/linux/highmem.h~crashdump-routines-for-copying-dump-pages-fixes include/linux/highmem.h
diff -puN kernel/crash_dump.c~crashdump-routines-for-copying-dump-pages-fixes kernel/crash_dump.c
--- 25/kernel/crash_dump.c~crashdump-routines-for-copying-dump-pages-fixes	Fri Feb  4 15:21:25 2005
+++ 25-akpm/kernel/crash_dump.c	Fri Feb  4 15:22:39 2005
@@ -28,6 +28,8 @@ ssize_t copy_oldmem_page(unsigned long p
 		return 0;
 
 	page = kmalloc(PAGE_SIZE, GFP_KERNEL);
+	if (!page)
+		return -ENOMEM;
 
 	vaddr = kmap_atomic_pfn(pfn, KM_PTE0);
 	copy_page(page, vaddr);
@@ -38,8 +40,9 @@ ssize_t copy_oldmem_page(unsigned long p
 			kfree(page);
 			return -EFAULT;
 		}
-	} else
+	} else {
 		memcpy(buf, page, csize);
+	}
 	kfree(page);
 
 	return 0;
_

                 reply	other threads:[~2005-03-28 14:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1112016436.4001.82.camel@localhost.localdomain \
    --to=vgoyal@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®