From: Daniel McNeil <daniel@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Badari Pulavarty <pbadari@us.ibm.com>,
sebastien.dugue@bull.net, jean-pierre.dion@bull.net,
gh@us.ibm.com, janetmor@us.ibm.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-aio@kvack.org" <linux-aio@kvack.org>
Subject: Re: [PATCH] Direct IO async short read bug followup
Date: Fri, 01 Apr 2005 17:43:27 -0800 [thread overview]
Message-ID: <1112406206.29841.31.camel@ibm-c.pdx.osdl.net> (raw)
In-Reply-To: <20050401172022.45d0cdd5.akpm@osdl.org>
On Fri, 2005-04-01 at 17:20, Andrew Morton wrote:
> Daniel McNeil <daniel@osdl.org> wrote:
> >
> > I updated the patch to add an i_size element to the dio structure and
> > sample i_size during i/o submission. When i/o completes the result can
> > be truncated to match the file size without using i_size_read(), thus
> > the aio result now matches the number of bytes read to the end of file.
> >
>
> Can you provide the analysis of the bug, please?
The direct i/o code is mapping the read request to the file system
block. If the file size was not on a block boundary, the result
would show the the read reading past EOF. This was only happening
for the AIO case. The non-AIO case truncates the result to match
file size (in direct_io_worker). This patch does the same thing
for the AIO case, it truncates the result to match the file size
if the read reads past EOF.
>
> >
> > Daniel
> >
> > --- linux-2.6.11.orig/fs/direct-io.c 2005-04-01 15:33:11.000000000 -0800
> > +++ linux-2.6.11/fs/direct-io.c 2005-03-31 16:59:15.000000000 -0800
> > @@ -66,6 +66,7 @@ struct dio {
> > struct bio *bio; /* bio under assembly */
> > struct inode *inode;
> > int rw;
> > + ssize_t i_size; /* i_size when submitted */
>
> I'll change this to loff_t, OK?
> -
Yes.
Daniel
prev parent reply other threads:[~2005-04-02 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1111743607.1299.85.camel@frecb000686>
[not found] ` <20050325014307.4395012e.akpm@osdl.org>
[not found] ` <1111745400.1299.89.camel@frecb000686>
[not found] ` <20050325022416.01c2535b.akpm@osdl.org>
[not found] ` <42442743.40600@us.ibm.com>
2005-04-02 1:11 ` Daniel McNeil
2005-04-02 1:20 ` Andrew Morton
2005-04-02 1:27 ` Andrew Morton
2005-04-02 1:44 ` Daniel McNeil
2005-04-02 1:43 ` Daniel McNeil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112406206.29841.31.camel@ibm-c.pdx.osdl.net \
--to=daniel@osdl.org \
--cc=akpm@osdl.org \
--cc=gh@us.ibm.com \
--cc=janetmor@us.ibm.com \
--cc=jean-pierre.dion@bull.net \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=sebastien.dugue@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®