From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix subarch breakage in intel_cacheinfo.c
Date: Sat, 02 Apr 2005 12:10:17 -0600 [thread overview]
Message-ID: <1112465417.5786.15.camel@mulgrave> (raw)
Not all x86 subarchitectures have support for hyperthreading, so every
piece you add for it has to be predicated on checks for CONFIG_X86_HT.
The patch corrects this hyperthreading leakage problem in
intel_cacheinfo.c
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
===== arch/i386/kernel/cpu/intel_cacheinfo.c 1.3 vs edited =====
--- 1.3/arch/i386/kernel/cpu/intel_cacheinfo.c 2005-03-31 05:06:44 -06:00
+++ edited/arch/i386/kernel/cpu/intel_cacheinfo.c 2005-04-02 12:03:39 -06:00
@@ -311,8 +311,10 @@
if (num_threads_sharing == 1)
cpu_set(cpu, this_leaf->shared_cpu_map);
+#ifdef CONFIG_X86_HT
else if (num_threads_sharing == smp_num_siblings)
this_leaf->shared_cpu_map = cpu_sibling_map[cpu];
+#endif
else
printk(KERN_INFO "Number of CPUs sharing cache didn't match "
"any known set of CPUs\n");
next reply other threads:[~2005-04-02 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-02 18:10 James Bottomley [this message]
2005-04-03 16:19 Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112465417.5786.15.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®