mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: John Keeping <john@metanate.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org" 
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 2/2] usb: dwc2: fix debugfs FIFO count
Date: Mon, 23 Dec 2019 09:11:17 +0000	[thread overview]
Message-ID: <11124aeb-ee8e-5794-5773-cdbcc662137c@synopsys.com> (raw)
In-Reply-To: <20191219113432.1229852-2-john@metanate.com>



On 12/19/2019 3:34 PM, John Keeping wrote:
> The number of FIFOs may be lower than the number of endpoints.  Use the
> correct total when printing FIFO details in debugfs.
> 
> Signed-off-by: John Keeping <john@metanate.com>
> ---

Acked-by: Minas Harutyunyan <hminas@synopsys.com>


>   drivers/usb/dwc2/debugfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c
> index b8f2790abf91..3a0dcbfbc827 100644
> --- a/drivers/usb/dwc2/debugfs.c
> +++ b/drivers/usb/dwc2/debugfs.c
> @@ -183,6 +183,7 @@ DEFINE_SHOW_ATTRIBUTE(state);
>   static int fifo_show(struct seq_file *seq, void *v)
>   {
>   	struct dwc2_hsotg *hsotg = seq->private;
> +	int fifo_count = dwc2_hsotg_tx_fifo_count(hsotg);
>   	u32 val;
>   	int idx;
>   
> @@ -196,7 +197,7 @@ static int fifo_show(struct seq_file *seq, void *v)
>   
>   	seq_puts(seq, "\nPeriodic TXFIFOs:\n");
>   
> -	for (idx = 1; idx < hsotg->num_of_eps; idx++) {
> +	for (idx = 1; idx <= fifo_count; idx++) {
>   		val = dwc2_readl(hsotg, DPTXFSIZN(idx));
>   
>   		seq_printf(seq, "\tDPTXFIFO%2d: Size %d, Start 0x%08x\n", idx,
> 

  reply	other threads:[~2019-12-23  9:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 11:34 [PATCH 1/2] usb: dwc2: Fix IN FIFO allocation John Keeping
2019-12-19 11:34 ` [PATCH 2/2] usb: dwc2: fix debugfs FIFO count John Keeping
2019-12-23  9:11   ` Minas Harutyunyan [this message]
2019-12-19 12:34 ` [PATCH 1/2] usb: dwc2: Fix IN FIFO allocation Minas Harutyunyan
2019-12-19 18:10   ` John Keeping
2019-12-23  9:10 ` Minas Harutyunyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11124aeb-ee8e-5794-5773-cdbcc662137c@synopsys.com \
    --to=minas.harutyunyan@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john@metanate.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®