From: Juerg Billeter <juerg@paldo.org>
To: len.brown@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix reloading GDT on ACPI S3 wakeup
Date: Fri, 08 Apr 2005 18:14:13 +0200 [thread overview]
Message-ID: <1112976854.8880.15.camel@juerg-p4.bitron.ch> (raw)
Hi
This patch - based on
http://marc.theaimsgroup.com/?l=linux-kernel&m=110055503031009&w=2 -
makes ACPI S3 wakeup work for me on a ThinkPad T40p laptop with a SMP
kernel. Without it only UP kernels work. I've been using the patch for
three months now without any issues.
The ACPI resume code currently uses a real-mode 16-bit lgdt instruction
to reload the GDT. This only restores the lower 24 bits of the GDT base
address. In recent SMP kernels, the GDT seems to have moved out of the
lower 16 megs, thereby causing the ACPI resume to fail -- an invalid GDT
was being loaded.
Regards,
Juerg
--
Signed-off-by: Juerg Billeter <juerg@paldo.org>
diff -uNr linux-2.6.10.orig/arch/i386/kernel/acpi/wakeup.S linux-2.6.10/arch/i386/kernel/acpi/wakeup.S
--- linux-2.6.10.orig/arch/i386/kernel/acpi/wakeup.S 2004-12-24 22:34:26.000000000 +0100
+++ linux-2.6.10/arch/i386/kernel/acpi/wakeup.S 2005-01-08 23:34:38.551471486 +0100
@@ -74,8 +74,9 @@
movw %ax,%fs
movw $0x0e00 + 'i', %fs:(0x12)
- # need a gdt
- lgdt real_save_gdt - wakeup_code
+ # need a gdt -- use lgdtl to force 32-bit operands, in case
+ # the GDT is located past 16 megabytes
+ lgdtl real_save_gdt - wakeup_code
movl real_save_cr0 - wakeup_code, %eax
movl %eax, %cr0
next reply other threads:[~2005-04-08 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-08 16:14 Juerg Billeter [this message]
2005-04-11 17:17 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112976854.8880.15.camel@juerg-p4.bitron.ch \
--to=juerg@paldo.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®