From: James Bottomley <James.Bottomley@SteelEye.com>
To: Andrew Morton <akpm@osdl.org>, Arjan van de Ven <arjanv@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] re-export cancel_rearming_delayed_workqueue
Date: Sun, 10 Apr 2005 14:07:23 -0500 [thread overview]
Message-ID: <1113160044.6737.12.camel@mulgrave> (raw)
This was unexported by Arjan because we have no current users.
However, during a conversion from tasklets to workqueues of the parisc
led functions, we ran across a case where this was needed. In
particular, the open coded equivalent of
cancel_rearming_delayed_workqueue was implemented incorrectly, which is,
I think, all the evidence necessary that this is a useful API.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
===== include/linux/workqueue.h 1.10 vs edited =====
--- 1.10/include/linux/workqueue.h 2005-02-15 15:56:55 -06:00
+++ edited/include/linux/workqueue.h 2005-04-05 11:13:50 -05:00
@@ -71,6 +71,8 @@
extern void init_workqueues(void);
void cancel_rearming_delayed_work(struct work_struct *work);
+void cancel_rearming_delayed_workqueue(struct workqueue_struct *,
+ struct work_struct *);
/*
* Kill off a pending schedule_delayed_work(). Note that the work callback
===== kernel/workqueue.c 1.33 vs edited =====
--- 1.33/kernel/workqueue.c 2005-02-22 21:23:08 -06:00
+++ edited/kernel/workqueue.c 2005-04-05 11:13:52 -05:00
@@ -429,12 +429,13 @@
* @wq: the controlling workqueue structure
* @work: the delayed work struct
*/
-static void cancel_rearming_delayed_workqueue(struct workqueue_struct *wq,
- struct work_struct *work)
+void cancel_rearming_delayed_workqueue(struct workqueue_struct *wq,
+ struct work_struct *work)
{
while (!cancel_delayed_work(work))
flush_workqueue(wq);
}
+EXPORT_SYMBOL(cancel_rearming_delayed_workqueue);
/**
* cancel_rearming_delayed_work - reliably kill off a delayed keventd
next reply other threads:[~2005-04-10 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-10 19:07 James Bottomley [this message]
2005-04-10 19:48 ` Arjan van de Ven
2005-04-10 21:11 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113160044.6737.12.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®