From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262007AbVDLCaC (ORCPT ); Mon, 11 Apr 2005 22:30:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262009AbVDLCaC (ORCPT ); Mon, 11 Apr 2005 22:30:02 -0400 Received: from gate.crashing.org ([63.228.1.57]:38298 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S262004AbVDLC3z (ORCPT ); Mon, 11 Apr 2005 22:29:55 -0400 Subject: Re: [PATCH] ppc32: refactor FPU exception handling From: Benjamin Herrenschmidt To: Kumar Gala Cc: Andrew Morton , Linux Kernel list , linuxppc-embedded , linuxppc-dev list , Jason McMullan In-Reply-To: References: Content-Type: text/plain Date: Tue, 12 Apr 2005 12:28:35 +1000 Message-Id: <1113272915.5388.37.camel@gaston> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2005-04-11 at 17:02 -0500, Kumar Gala wrote: > Andrew, > > Moved common FPU exception handling code out of head.S so it can be used > by several of the sub-architectures that might of a full PowerPC FPU. > > Also, uses new CONFIG_PPC_FPU define to fix alignment exception > handling for floating point load/store instructions to only occur if we > have a hardware FPU. > > Signed-off-by: Jason McMullan > Signed-off-by: Kumar Gala Andrew, please hold on this patch, it hasn't been properly discussed with the relevant maintainer, that is Paul Mackerras. I can see matter for debate in there, like the whole duplication of the fast exception return path... It's also touching quite sensitive bits of kernel code (head.S) that needs careful auditing and testing before beeing pushed upstream. Ben.