mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: tsuchiya yoshihiro <yt@labs.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: SLEEP_ON_BKLCHECK
Date: Thu, 14 Apr 2005 08:46:30 +0200	[thread overview]
Message-ID: <1113461190.6293.1.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <425DBC76.60804@labs.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

On Thu, 2005-04-14 at 09:42 +0900, tsuchiya yoshihiro wrote:
> Hi,
> In Fedora Core3, interruptible_sleep_on() checks if the system is
> lock_kernel()'ed
> by SLEEP_ON_BKLCHECK. Same thing is done in RedHatEL4.
> Also I found a patch including SLEEP_ON_BKLCHECK was posted before,
> but is not included in 2.6.11.
> Why SLEEP_ON_BKLCHECK checks lock_kernel ?

Because you really need to hold the BKL when you call sleep_on() family
of APIs, otherwise you have a very big race.

Also note that you in your code really should not call any of the
sleep_on() family of functions at all! It is a very very deprecated and
defective API!!!!

Can you give the URL to the code where you use this in?
(it is GPL code, right?)

Greetings,
    Arjan van de Ven

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2005-04-14  6:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-14  0:42 SLEEP_ON_BKLCHECK tsuchiya yoshihiro
2005-04-14  6:46 ` Arjan van de Ven [this message]
2005-04-14  7:17   ` SLEEP_ON_BKLCHECK tsuchiya yoshihiro
2005-04-14  7:21     ` SLEEP_ON_BKLCHECK Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1113461190.6293.1.camel@laptopd505.fenrus.org \
    --to=arjanv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yt@labs.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®