mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jesper Juhl <juhl-lkml@dif.dk>, Ingo Molnar <mingo@elte.hu>,
	rml@tech9.net, torvalds@osdl.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: fix never executed code due to expression always false
Date: Fri, 15 Apr 2005 13:25:20 +1000	[thread overview]
Message-ID: <1113535520.6517.18.camel@npiggin-nld.site> (raw)
In-Reply-To: <E1DMH3H-0006Jg-00@gondolin.me.apana.org.au>

On Fri, 2005-04-15 at 12:59 +1000, Herbert Xu wrote:
> Jesper Juhl <juhl-lkml@dif.dk> wrote:
> >
> > -               if (unlikely((long long)now - prev->timestamp < 0))
> > +               if (unlikely(((long long)now - (long long)prev->timestamp) < 0))
> 
> You can write this as
> 
> (long long)(now - prev->timestamp)
> 

True. Combined that with Matt's suggestion, and we probably have
the cleanest solution. Thanks.




  reply	other threads:[~2005-04-15  3:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-14 23:49 Jesper Juhl
2005-04-15  0:09 ` Nick Piggin
2005-04-15  0:14   ` Jesper Juhl
2005-04-15  0:13     ` Nick Piggin
2005-04-15  0:23       ` Jesper Juhl
2005-04-15  0:23         ` Nick Piggin
2005-04-15  2:32           ` Matt Mackall
2005-04-15  2:59         ` Herbert Xu
2005-04-15  3:25           ` Nick Piggin [this message]
2005-04-15  7:58         ` Ingo Molnar
2005-04-16 13:54           ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1113535520.6517.18.camel@npiggin-nld.site \
    --to=nickpiggin@yahoo.com.au \
    --cc=herbert@gondor.apana.org.au \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rml@tech9.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®