From: Arjan van de Ven <arjan@infradead.org>
To: mike.miller@hp.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
marcelo.tosatti@cyclades.com
Subject: Re: [RFC 1 of 9] patches to add diskdump functionality to block layer
Date: Mon, 18 Apr 2005 17:47:07 +0200 [thread overview]
Message-ID: <1113839227.6274.80.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20050418153644.GA25409@beardog.cca.cpqcorp.net>
On Mon, 2005-04-18 at 10:36 -0500, mike.miller@hp.com wrote:
> +
> +/*
> + * Extended block operations for dump for preserving binary compatibility.
> + */
> +struct block_dump_ops {
> + int (*sanity_check)(void *device);
> + int (*rw_block)(void *device, int rw, unsigned long dump_block_nr, void *buf, int len, unsigned long start_sect, unsigned long nr_sects);
> + int (*quiesce)(void *device);
> + int (*shutdown)(void *device);
> +};
this looks wrong. In linux we don't care about module ABI, and just go
for the clean solution instead! (eg in this case, just put the methods
in the block dev ops)
next prev parent reply other threads:[~2005-04-18 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-18 15:36 mike.miller
2005-04-18 15:42 ` Christoph Hellwig
2005-04-18 11:44 ` Marcelo Tosatti
2005-04-18 15:43 ` Arjan van de Ven
2005-04-18 15:47 ` Arjan van de Ven [this message]
2005-04-18 17:14 Miller, Mike (OS Dev)
2005-04-18 19:40 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113839227.6274.80.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®