From: Li Shaohua <shaohua.li@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: ACPI-DEV <acpi-devel@lists.sourceforge.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@suse.cz>,
Zwane Mwaikambo <zwane@linuxpower.ca>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6]cpu state clean after hot remove
Date: Thu, 21 Apr 2005 11:36:26 +0800 [thread overview]
Message-ID: <1114054585.26501.4.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <1113283859.27646.430.camel@sli10-desk.sh.intel.com>
On Tue, 2005-04-12 at 13:31, Li Shaohua wrote:
> @@ -1052,7 +1086,7 @@ static void __init smp_boot_cpus(unsigne
> if (max_cpus <= cpucount+1)
> continue;
>
> - if (do_boot_cpu(apicid))
> + if ((cpu = alloc_cpu_id() > 0) && do_boot_cpu(apicid, cpu))
> printk("CPU #%d not responding - cannot use it.\n",
> apicid);
> else
Oops, there is a typo in the patch. Andrew, please apply below patch
against above patch. Sorry for the inconvenience.
Thanks,
Shaohua
---
linux-2.6.11-root/arch/i386/kernel/smpboot.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN arch/i386/kernel/smpboot.c~smpboot arch/i386/kernel/smpboot.c
--- linux-2.6.11/arch/i386/kernel/smpboot.c~smpboot 2005-04-21 11:27:53.913041424 +0800
+++ linux-2.6.11-root/arch/i386/kernel/smpboot.c 2005-04-21 11:28:44.103411328 +0800
@@ -1166,7 +1166,7 @@ static void __init smp_boot_cpus(unsigne
if (max_cpus <= cpucount+1)
continue;
- if ((cpu = alloc_cpu_id() > 0) && do_boot_cpu(apicid, cpu))
+ if (((cpu = alloc_cpu_id()) <= 0) || do_boot_cpu(apicid, cpu))
printk("CPU #%d not responding - cannot use it.\n",
apicid);
else
_
prev parent reply other threads:[~2005-04-21 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 5:31 Li Shaohua
2005-04-21 3:36 ` Li Shaohua [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114054585.26501.4.camel@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®