From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <andrea@suse.de>
Subject: Re: [patch] fix race in __block_prepare_write (again)
Date: Thu, 21 Apr 2005 17:13:19 +1000 [thread overview]
Message-ID: <1114067599.5182.17.camel@npiggin-nld.site> (raw)
In-Reply-To: <Pine.LNX.4.60.0504210757220.3348@hermes-1.csi.cam.ac.uk>
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
> Any reason why you left the goto out? It would be IMO much cleaner to
> remove the label "out" altogether and replace the single "goto out" with a
> "break" (which is fine since the goto happens inside the for loop
> immediately after which you place the label.)
>
No reason at all ;)
--
SUSE Labs, Novell Inc.
prev parent reply other threads:[~2005-04-21 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 6:14 Nick Piggin
2005-04-21 7:01 ` Anton Altaparmakov
2005-04-21 7:10 ` Anton Altaparmakov
2005-04-21 7:20 ` Nick Piggin
2005-04-21 7:31 ` Anton Altaparmakov
2005-04-22 15:10 ` Nikita Danilov
2005-04-22 15:50 ` Anton Altaparmakov
2005-04-24 21:24 ` Andrew Morton
2005-04-25 7:44 ` Anton Altaparmakov
2005-04-21 7:13 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114067599.5182.17.camel@npiggin-nld.site \
--to=nickpiggin@yahoo.com.au \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®