From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Albert Lee <trisk@jhu.edu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hpt366: HPT372N rev 2 controller fix
Date: Thu, 21 Apr 2005 10:47:20 +0100 [thread overview]
Message-ID: <1114076839.7656.78.camel@localhost.localdomain> (raw)
In-Reply-To: <200504210154.20031.trisk@jhu.edu>
On Iau, 2005-04-21 at 06:54, Albert Lee wrote:
> A particular revision of the HPT372N oopses hpt366 consistently. It's a
> regression caused by Alan's changes in 2.6.9 to support the HPT372N using
> only PLL timings. The driver works correctly in prior versions, where the the
> PCI clock is used instead. This patch restores that behaviour for this
> particular revision.
For some drives, if you are lucky. The problem is that the PLL code in
the hpt366 driver is simply wrong. The -ac tree has some cleanup work in
this area but hasn't fixed the PLL code yet. The vendor driver does
handle this chip correctly.
Linus please avoid this patch - better an oops than disk corruption.
Alan
prev parent reply other threads:[~2005-04-21 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 5:54 Albert Lee
2005-04-21 9:47 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114076839.7656.78.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=trisk@jhu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®