From: Li Shaohua <shaohua.li@intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Antonino A. Daplas" <adaplas@pol.net>,
Pavel Machek <pavel@ucw.cz>, lkml <linux-kernel@vger.kernel.org>,
ACPI-DEV <acpi-devel@lists.sourceforge.net>,
Len Brown <len.brown@intel.com>,
Zwane Mwaikambo <zwane@linuxpower.ca>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH 6/6]suspend/resume SMP support
Date: Mon, 25 Apr 2005 08:49:25 +0800 [thread overview]
Message-ID: <1114390165.29778.8.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <20050423153501.5286b6c6.akpm@osdl.org>
On Sun, 2005-04-24 at 06:35, Andrew Morton wrote:
> fbcon is trying to call kmalloc before the slab system is initialised.
> It would be best to fix that within fbcon.
This solves the problem too.
> Well as the comment says, if this CPU isn't online yet, and if the system
> has not yet reached SYSTEM_RUNNING state then we bale out of the printk
> because this cpu's per-cpu resources may not yet be fully set up.
After the CPU is offline (we are doing CPU hotplug). Its per-cpu
resources like kmalloc also aren't initialized. This is in
SYSTEM_RUNNING state too, so the system state doesn't matter. Removing
the system state check seems better than fixing the fbcon driver to me.
Thanks,
Shaohua
next prev parent reply other threads:[~2005-04-25 0:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 5:31 Li Shaohua
2005-04-12 9:43 ` Pavel Machek
2005-04-12 10:51 ` Pavel Machek
2005-04-12 12:40 ` Li Shaohua
2005-04-13 8:32 ` Pavel Machek
2005-04-14 8:27 ` Li Shaohua
2005-04-14 8:40 ` Li Shaohua
2005-04-23 22:35 ` Andrew Morton
2005-04-23 22:41 ` Pavel Machek
2005-04-25 0:49 ` Li Shaohua [this message]
2005-05-26 2:58 ` Hotplug CPU printk issue Shaohua Li
2005-05-26 3:48 ` Andrew Morton
2005-05-26 5:43 ` Shaohua Li
2005-05-26 5:52 ` Andrew Morton
2005-05-26 19:32 ` David Mosberger
2005-05-27 2:08 ` Rusty Russell
2005-04-28 7:22 ` [PATCH 6/6]suspend/resume SMP support Andrew Morton
2005-04-28 7:28 ` Li Shaohua
2005-04-28 7:41 ` Andrew Morton
2005-04-28 8:29 ` Li Shaohua
2005-04-28 8:35 ` Pavel Machek
2005-04-28 9:04 ` [ACPI] " Rafael J. Wysocki
2005-04-28 7:35 ` Li Shaohua
2005-04-28 7:42 ` Pavel Machek
2005-04-28 8:11 ` [ACPI] " Yu, Luming
2005-04-28 8:20 ` Pavel Machek
2005-04-28 8:34 ` Yu, Luming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114390165.29778.8.camel@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=adaplas@pol.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®