From: Li Shaohua <shaohua.li@intel.com>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH]broadcast IPI race condition on CPU hotplug
Date: Tue, 26 Apr 2005 12:24:50 +0800 [thread overview]
Message-ID: <1114489490.7416.2.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0504252222230.26521@montezuma.fsmlabs.com>
Hi,
On Tue, 2005-04-26 at 12:25, Zwane Mwaikambo wrote:
>
> > After a CPU is booted but before it's officially up (set online map, and
> > enable interrupt), the CPU possibly will receive a broadcast IPI. After
> > it's up, it will handle the stale interrupt soon and maybe cause oops if
> > it's a smp-call-function-interrupt. This is quite possible in CPU
> > hotplug case, but nearly can't occur at boot time. Below patch replaces
> > broadcast IPI with send_ipi_mask just like the cluster mode.
>
> Ok, but isn't it sufficient to use send_ipi_mask in smp_call_function
> instead?
I'm not sure if other routines using broadcast IPI have this bug. Fixing
the send_ipi_all API looks more generic. Is there any reason we should
use broadcast IPI?
Thanks,
Shaohua
next prev parent reply other threads:[~2005-04-26 4:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-26 2:20 Li Shaohua
2005-04-26 4:25 ` Zwane Mwaikambo
2005-04-26 4:24 ` Li Shaohua [this message]
2005-04-26 4:47 ` Zwane Mwaikambo
2005-04-26 5:17 ` Li Shaohua
2005-04-26 13:21 ` Andi Kleen
2005-04-27 1:00 ` Zwane Mwaikambo
2005-04-27 1:11 ` Li Shaohua
2005-04-27 12:56 ` Andi Kleen
2005-04-28 3:15 ` Li Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114489490.7416.2.camel@sli10-desk.sh.intel.com \
--to=shaohua.li@intel.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®