From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jens Axboe <axboe@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: IDE problems with rmmod ide-cd
Date: Fri, 29 Apr 2005 15:03:06 +0100 [thread overview]
Message-ID: <1114783384.18355.283.camel@localhost.localdomain> (raw)
In-Reply-To: <1114727044.18330.232.camel@localhost.localdomain>
On Iau, 2005-04-28 at 23:24, Alan Cox wrote:
> One possibility might be that the specific drive is incorrectly
> reporting capabilities and register_cdrom is setting cdi->exit as a
> result. Will try and work out what is going on there tomorrow.
Looks like a dumb bug in ide-cd. The error is coming from mrw_exit.
That gets called because ide-cd sets mask to 0 "I do everything" and
then subtracts features by checking drive bits. What it should do is set
the mask to every flag it knows about and then work back.
The ide-cd code doesn't know about CDC_MRW_W so its always a zero bit in
the mask, CDROM_CAN(CDC_MRW_W) is always true and cache flushes get
written.
Alan
prev parent reply other threads:[~2005-04-29 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 16:44 Alan Cox
2005-04-28 17:25 ` Jens Axboe
2005-04-28 20:46 ` Bartlomiej Zolnierkiewicz
2005-04-28 21:51 ` Alan Cox
2005-04-28 22:20 ` Bartlomiej Zolnierkiewicz
2005-04-28 22:24 ` Alan Cox
2005-04-29 14:03 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114783384.18355.283.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome