From: David Woodhouse <dwmw2@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, dedekind@infradead.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] VFS bugfix: two read_inode() calles without clear_inode() call between
Date: Fri, 06 May 2005 12:08:49 +0100 [thread overview]
Message-ID: <1115377730.16187.189.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <E1DTj3z-0005By-00@dorka.pomaz.szeredi.hu>
On Thu, 2005-05-05 at 18:18 +0200, Miklos Szeredi wrote:
> Using yield() to wait for a precisely defined event (clear_inode()
> finishing) doesn't seem like a very good idea. Especially, since
> Artem's patch will probably make it trigger more often.
Agreed. Even before Artem's patch, we're still effectively busy-waiting
for something which calls back into the file system's clear_inode method
and may well sleep and perform I/O.
> How about this (totally untested) patch? Even if I_LOCK is not set
> initially, wake_up_inode() should do the right thing and wake up the
> waiting task after clear_inode(). It shouldn't cause spurious
> wakeups, since there should be no other reference to the inode.
Since Artem introduced a wake_up_inode() in dispose_list(), your patch
seems reasonable.
--
dwmw2
next prev parent reply other threads:[~2005-05-06 11:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 13:15 Artem B. Bityuckiy
2005-04-27 13:42 ` Jan Harkes
2005-04-27 14:22 ` Miklos Szeredi
2005-04-27 15:57 ` Miklos Szeredi
2005-04-27 16:19 ` Artem B. Bityuckiy
[not found] ` <E1DQqZu-0002Rf-00@dorka.pomaz.szeredi.hu>
2005-04-28 7:32 ` Artem B. Bityuckiy
2005-04-28 7:34 ` Andrew Morton
2005-05-04 12:17 ` Artem B. Bityuckiy
2005-05-04 20:04 ` Andrew Morton
2005-05-04 21:35 ` David Woodhouse
2005-05-04 21:58 ` Andrew Morton
2005-05-05 9:10 ` David Woodhouse
2005-05-05 16:18 ` Miklos Szeredi
2005-05-06 11:08 ` David Woodhouse [this message]
2005-04-28 7:41 ` Miklos Szeredi
2005-04-28 7:47 ` Artem B. Bityuckiy
-- strict thread matches above, loose matches on Subject: below --
2005-04-19 12:38 Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115377730.16187.189.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=dedekind@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®