From: David Woodhouse <dwmw2@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@osdl.org, dedekind@infradead.org, wli@holomorphy.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] __wait_on_freeing_inode fix
Date: Fri, 06 May 2005 14:33:24 +0100 [thread overview]
Message-ID: <1115386405.16187.196.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <E1DU1Hy-00060Q-00@dorka.pomaz.szeredi.hu>
On Fri, 2005-05-06 at 13:46 +0200, Miklos Szeredi wrote:
> The solution is to restore the old behavior, of unconditionally
> waiting on the waitqueue. It doesn't matter if I_LOCK is not set
> initally, the task will go to sleep, and wake up when wake_up_inode()
> is called from generic_delete_inode() after removing the inode from
> the hash chain.
That's all well and good if it's actually generic_delete_inode() which
removes the inode from the hash chain. But if it's prune_icache() which
does that, you don't get the wakeup.
Applying Artem's patch will fix that.
--
dwmw2
next prev parent reply other threads:[~2005-05-06 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 11:46 Miklos Szeredi
2005-05-06 12:14 ` Artem B. Bityuckiy
2005-05-06 12:19 ` Miklos Szeredi
2005-05-06 13:33 ` David Woodhouse [this message]
2005-05-06 13:38 ` Miklos Szeredi
2005-05-06 13:44 ` Artem B. Bityuckiy
2005-05-06 13:49 ` Miklos Szeredi
2005-05-06 13:52 ` David Woodhouse
2005-05-06 13:52 ` Artem B. Bityuckiy
2005-05-11 14:19 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115386405.16187.196.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=dedekind@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®