mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Abhay Salunke <Abhay_Salunke@dell.com>,
	linux-kernel@vger.kernel.org, matt_domsch@dell.com,
	Greg KH <greg@kroah.com>
Subject: Re: [patch 2.6.12-rc3] dell_rbu: New Dell BIOS update driver
Date: Wed, 11 May 2005 10:35:18 +0200	[thread overview]
Message-ID: <1115800518.6029.19.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20050510165925.271d7967.akpm@osdl.org>

On Tue, 2005-05-10 at 16:59 -0700, Andrew Morton wrote:

> > +			
> > +			/* free this memory as we need it with in 4GB range */
> > +			free_pages ((unsigned long)pbuf, *ordernum);
> > +			
> > +			/* try allocating a new buffer from the GFP_DMA range 
> > +			   as it is with in 16MB range.*/
> > +			pbuf =(unsigned char *)__get_free_pages(GFP_DMA, *ordernum);
> > +			
> > +			if (pbuf == NULL)
> > +				pr_debug("Failed to get memory of size %ld using GFP_DMA\n", size);
> > +		}
> > +	}
> > +	return pbuf;
> > +}
> 
> What architecture is this code designed for?  On x86 a GFP_KERNEL
> allocation will never return highmem.  I guess x86_64?
> 
> I assume this code is here because the x86_64 BIOS will only access the
> lower 4GB?  If so, a comment to that extent would be useful.
> 
> Sometime I expect that x86_64 will gain a new zone, GFP_DMA32 which will be
> guaranteed to return memory below he 4GB point.  When that happens, this
> driver should be converted to use it.

Almost always when this happens the driver actually wanted to use
pci_alloc_consistent memory... (i've not seen the rest of the driver yet
so can't say how appropriate that would be here)



  reply	other threads:[~2005-05-11  8:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-10 22:05 Abhay Salunke
2005-05-10 23:59 ` Andrew Morton
2005-05-11  8:35   ` Arjan van de Ven [this message]
2005-05-11  7:19 ` Greg KH
2005-05-11  8:49 ` Arjan van de Ven
2005-05-11  9:57 ` Xavier Bestel
2005-05-11 22:05 ` Matt Domsch
2005-05-11 15:25 Abhay_Salunke
2005-05-11 18:21 Abhay_Salunke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1115800518.6029.19.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=Abhay_Salunke@dell.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt_domsch@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®