mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: David Lechner <dlechner@baylibre.com>,
	Jonathan Cameron <jic23@kernel.org>,
	 linux-iio@vger.kernel.org
Cc: Michael Hennerich <Michael.Hennerich@analog.com>,
	Angelo Dureghello <adureghello@baylibre.com>,
	Alexandru Ardelean <aardelean@baylibre.com>,
	 Beniamin Bia <beniamin.bia@analog.com>,
	Stefan Popa <stefan.popa@analog.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] iio: adc: ad7606: improvements and ad7606c parallel interface support
Date: Thu, 13 Mar 2025 21:11:19 +0000	[thread overview]
Message-ID: <111613449ea7effdcbea1c987c66f927182d8395.camel@gmail.com> (raw)
In-Reply-To: <20250312-iio-adc-ad7606-improvements-v1-0-d1ec04847aea@baylibre.com>

On Wed, 2025-03-12 at 20:15 -0500, David Lechner wrote:
> The main purpose of this series is to add support for the AD7606C chips
> using a parallel interface. Along the way quite a few improvements were
> made to the driver which in the end made adding the additional chips
> trivial.
> 
> The first 3 patches are fixes. The next 6 are some minor cleanups. The
> 2nd to last patch is the big one. As explained in the respective commit
> message, the channel data structures were getting out of hand and only
> going to get worse with the addition of SPI offload support. Instead, we
> are opting to dynamically allocate the channel data structures to avoid
> a bunch of the existing complexity in the driver.
> 
> I have limited access to hardware, so I was only able to test this with
> ad7606c-18.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> David Lechner (11):
>       iio: adc: ad7606_spi: check error in ad7606B_sw_mode_config()
>       iio: adc: ad7606: check for NULL before calling sw_mode_config()
>       iio: adc: ad7606: fix scales_available attributes
>       iio: adc: ad7606: add missing max sample rates
>       iio: adc: ad7606: use devm_mutex_init()
>       iio: adc: ad7606: fix kernel-doc comments
>       iio: adc: ad7606: use kernel identifier name style
>       iio: adc: ad7606: don't use address field
>       iio: adc: ad7606: drop ch param from ad7606_scale_setup_cb_t
>       iio: adc: ad7606: dynamically allocate channel info
>       iio: adc: ad7606_par: add ad7606c chips
> 
>  drivers/iio/adc/ad7606.c     | 313 ++++++++++++++++++++-----------------------
>  drivers/iio/adc/ad7606.h     | 171 +++++++----------------
>  drivers/iio/adc/ad7606_par.c |  37 +----
>  drivers/iio/adc/ad7606_spi.c |  98 ++------------
>  4 files changed, 211 insertions(+), 408 deletions(-)
> ---
> base-commit: 97fe5f8a4299e4b8601ecb62c9672c27f2d2ccce
> change-id: 20250311-iio-adc-ad7606-improvements-997d7af218e3
> 
> Best regards,


      parent reply	other threads:[~2025-03-13 21:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-13  1:15 David Lechner
2025-03-13  1:15 ` [PATCH 01/11] iio: adc: ad7606_spi: check error in ad7606B_sw_mode_config() David Lechner
2025-03-15 18:48   ` Jonathan Cameron
2025-03-13  1:15 ` [PATCH 02/11] iio: adc: ad7606: check for NULL before calling sw_mode_config() David Lechner
2025-03-13  1:15 ` [PATCH 03/11] iio: adc: ad7606: fix scales_available attributes David Lechner
2025-03-13  1:15 ` [PATCH 04/11] iio: adc: ad7606: add missing max sample rates David Lechner
2025-03-13  1:15 ` [PATCH 05/11] iio: adc: ad7606: use devm_mutex_init() David Lechner
2025-03-15 18:52   ` Jonathan Cameron
2025-03-13  1:15 ` [PATCH 06/11] iio: adc: ad7606: fix kernel-doc comments David Lechner
2025-03-15 18:55   ` Jonathan Cameron
2025-03-13  1:15 ` [PATCH 07/11] iio: adc: ad7606: use kernel identifier name style David Lechner
2025-03-13  1:15 ` [PATCH 08/11] iio: adc: ad7606: don't use address field David Lechner
2025-03-13  1:15 ` [PATCH 09/11] iio: adc: ad7606: drop ch param from ad7606_scale_setup_cb_t David Lechner
2025-03-13  1:15 ` [PATCH 10/11] iio: adc: ad7606: dynamically allocate channel info David Lechner
2025-03-15 19:02   ` Jonathan Cameron
2025-03-13  1:15 ` [PATCH 11/11] iio: adc: ad7606_par: add ad7606c chips David Lechner
2025-03-13 21:11 ` Nuno Sá [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=111613449ea7effdcbea1c987c66f927182d8395.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=aardelean@baylibre.com \
    --cc=adureghello@baylibre.com \
    --cc=beniamin.bia@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan.popa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®