From: Arjan van de Ven <arjan@infradead.org>
To: "Bagalkote, Sreenivas" <sreenib@lsil.com>
Cc: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'Matt_Domsch@Dell.com'" <Matt_Domsch@Dell.com>,
Andrew Morton <akpm@osdl.org>,
"'Christoph Hellwig'" <hch@infradead.org>,
"'James Bottomley'" <James.Bottomley@SteelEye.com>
Subject: Re: [PATCH 2.6.12-rc4-mm1 3/4] megaraid_sas: updating the driver
Date: Mon, 16 May 2005 10:06:16 +0200 [thread overview]
Message-ID: <1116230776.6274.20.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E57060CCE7C@exa-atlanta>
> +
> + if (exception) {
> +
> + spin_lock( instance->host_lock );
> + cmd->scmd->scsi_done( cmd->scmd );
> + spin_unlock( instance->host_lock );
are you really sure you don't want to use spin_lock_irqsave() here ?
> + unregister_chrdev( megasas_mgmt_majorno, "megaraid_sas_ioctl" );
I really don't like this idea of weird ioctl devices though...
next prev parent reply other threads:[~2005-05-16 8:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-16 6:57 Bagalkote, Sreenivas
2005-05-16 8:06 ` Arjan van de Ven [this message]
2005-05-16 14:18 ` James Bottomley
2005-05-16 14:24 ` Arjan van de Ven
2005-05-16 14:50 ` 'Christoph Hellwig'
2005-05-17 22:13 Bagalkote, Sreenivas
2005-05-17 23:51 Bagalkote, Sreenivas
2005-05-18 13:53 ` 'Christoph Hellwig'
2005-05-24 20:45 Salyzyn, Mark
2005-05-24 21:16 ` Arjan van de Ven
2005-05-25 5:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116230776.6274.20.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=Matt_Domsch@Dell.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®