From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261367AbVEXGnN (ORCPT ); Tue, 24 May 2005 02:43:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261355AbVEXGnD (ORCPT ); Tue, 24 May 2005 02:43:03 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:38285 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S261367AbVEXGkv (ORCPT ); Tue, 24 May 2005 02:40:51 -0400 Subject: Re: [CRYPTO]: Only reschedule if !in_atomic() From: Arjan van de Ven To: Linux Kernel Mailing List Cc: davem@davemloft.net In-Reply-To: <200505232300.j4NN07lE012726@hera.kernel.org> References: <200505232300.j4NN07lE012726@hera.kernel.org> Content-Type: text/plain Date: Tue, 24 May 2005 08:40:45 +0200 Message-Id: <1116916845.6280.8.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit X-Spam-Score: 3.7 (+++) X-Spam-Report: SpamAssassin version 2.63 on pentafluge.infradead.org summary: Content analysis details: (3.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.1 RCVD_IN_DSBL RBL: Received via a relay in list.dsbl.org [] 2.5 RCVD_IN_DYNABLOCK RBL: Sent directly from dynamic IP address [80.57.133.107 listed in dnsbl.sorbs.net] 0.1 RCVD_IN_SORBS RBL: SORBS: sender is listed in SORBS [80.57.133.107 listed in dnsbl.sorbs.net] X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > - if (!in_softirq()) > + if (!in_atomic()) > cond_resched(); this looks wrong. in_atomic() isn't doing what I think you think it does; for one it doesn't get set inside spinlock regions (unless preempt is enabled)