mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Nyberg <alexn@telia.com>
To: Pete Clements <clem@clem.clem-digital.net>
Cc: torvalds@osdl.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.12-rc5-git3 fails compile -- acpi_boot_table_init
Date: Sat, 28 May 2005 15:37:19 +0200	[thread overview]
Message-ID: <1117287439.952.17.camel@localhost.localdomain> (raw)
In-Reply-To: <200505281206.j4SC6iLa015878@clem.clem-digital.net>

lör 2005-05-28 klockan 08:06 -0400 skrev Pete Clements:
> Fyi:
> 
> 
>   LD      .tmp_vmlinux1
> arch/i386/kernel/built-in.o: In function `setup_arch':
> arch/i386/kernel/built-in.o(.init.text+0x14ec): undefined reference to `acpi_boot_table_init'
> arch/i386/kernel/built-in.o(.init.text+0x14f1): undefined reference to `acpi_boot_init'
> make: *** [.tmp_vmlinux1] Error 1
> 

This is a neverending story

linux/acpi.h contains empty declarations for acpi_boot_init() &
acpi_boot_table_init() but they are nested inside #ifdef CONFIG_ACPI.

So we'll have to #ifdef in arch/i386/kernel/setup.c: setup_arch()

Signed-off-by: Alexander Nyberg <alexn@telia.com>

Index: meep/arch/i386/kernel/setup.c
===================================================================
--- meep.orig/arch/i386/kernel/setup.c	2005-05-28 14:39:06.000000000 +0200
+++ meep/arch/i386/kernel/setup.c	2005-05-28 14:59:34.000000000 +0200
@@ -1502,11 +1502,13 @@
 	if (efi_enabled)
 		efi_map_memmap();
 
+#ifdef CONFIG_ACPI_BOOT
 	/*
 	 * Parse the ACPI tables for possible boot-time SMP configuration.
 	 */
 	acpi_boot_table_init();
 	acpi_boot_init();
+#endif
 
 #ifdef CONFIG_X86_LOCAL_APIC
 	if (smp_found_config)



  reply	other threads:[~2005-05-28 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-28 12:06 Pete Clements
2005-05-28 13:37 ` Alexander Nyberg [this message]
2005-05-29 18:58   ` Linus Torvalds
2005-05-29 19:17     ` Alexander Nyberg
2005-05-31 14:09     ` Steven Cole
2005-05-31 20:00       ` Christian Kujau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1117287439.952.17.camel@localhost.localdomain \
    --to=alexn@telia.com \
    --cc=clem@clem.clem-digital.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®