From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753738AbbEAN0I (ORCPT ); Fri, 1 May 2015 09:26:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44213 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbbEAN0G (ORCPT ); Fri, 1 May 2015 09:26:06 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <54EDCB9E.4080602@suse.cz> References: <54EDCB9E.4080602@suse.cz> <20150206145834.17303.59753.stgit@warthog.procyon.org.uk> <20150206145914.17303.58238.stgit@warthog.procyon.org.uk> To: Michal Marek Cc: dhowells@redhat.com, rusty@rustcorp.com.au, keyrings@linux-nfs.org, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 4/5] MODSIGN: Provide a utility to append a PKCS#7 signature to a module [ver #3] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11176.1430486760.1@warthog.procyon.org.uk> Date: Fri, 01 May 2015 14:26:01 +0100 Message-ID: <11177.1430486761@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Marek wrote: > > + ERR(asprintf(&dest_name, "%s.~signed~", module_name) < 0, > > + "asprintf"); > > + replace_orig = true; > > + } > > + > > + ERR_load_crypto_strings(); > > + ERR_clear_error(); > > The error queue initialization should be done before the first use of > the ERR() macro. Or the asprintf check should be open-coded, because it > has nothing to do with openssl. Good point. David