mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: David Teigland <teigland@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 6/9] dlm: clear recovery flags
Date: Thu, 02 Jun 2005 10:19:20 +0200	[thread overview]
Message-ID: <1117700360.6458.25.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20050602080301.GF21570@redhat.com>

On Thu, 2005-06-02 at 16:03 +0800, David Teigland wrote:
> plain text document attachment (clear-recovery-flags.patch)
> At the start of recovery, all the recovery flags are cleared from the
> previous recovery.  Two of them weren't being cleared.
> 
> Signed-off-by: David Teigland <teigland@redhat.com>
> 
> Index: linux/drivers/dlm/member.c
> ===================================================================
> --- linux.orig/drivers/dlm/member.c	2005-06-02 12:28:30.000000000 +0800
> +++ linux/drivers/dlm/member.c	2005-06-02 13:07:46.060566696 +0800
> @@ -276,6 +276,8 @@
>  	 */
>  
>  	dlm_recoverd_suspend(ls);
> +	clear_bit(LSFL_LOCKS_VALID, &ls->ls_flags);
> +	clear_bit(LSFL_ALL_LOCKS_VALID, &ls->ls_flags);
>  	clear_bit(LSFL_DIR_VALID, &ls->ls_flags);
>  	clear_bit(LSFL_ALL_DIR_VALID, &ls->ls_flags);
>  	clear_bit(LSFL_NODES_VALID, &ls->ls_flags);

btw do these need to be atomic? right now these are atomic ops and thus
very expensive... you might want to switch to nonatomic variants if
that's not needed.



  reply	other threads:[~2005-06-02  8:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-02  8:03 David Teigland
2005-06-02  8:19 ` Arjan van de Ven [this message]
2005-06-02  9:30   ` David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1117700360.6458.25.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®