Re: TPM on IBM thinkcenter S51

[Kylene Jo Hall <kjhall@us.ibm.com>]

The second patch that may be necessary to fix the NSC TPM command path.
Please let me know your results.

Thanks,
Kylie

Signed-off-by: Kylene Hall
---
--- linux-2.6.12-rc4/drivers/char/tpm/tpm_nsc.orig	2005-06-03 10:50:45.000000000 -0500
+++ linux-2.6.12-rc4/drivers/char/tpm/tpm_nsc.c	2005-06-03 10:51:09.000000000 -0500
@@ -149,7 +149,7 @@ static int tpm_nsc_recv(struct tpm_chip 
 			break;
 		*p = inb(chip->vendor->base + NSC_DATA);
 	}
-
+/*
 	if ((data & NSC_STATUS_F0) == 0) {
 		dev_err(&chip->pci_dev->dev, "F0 not set\n");
 		return -EIO;
@@ -159,7 +159,7 @@ static int tpm_nsc_recv(struct tpm_chip 
 			"expected end of command(0x%x)\n", data);
 		return -EIO;
 	}
-
+*/
 	native_size = (__force __be32 *) (buf + 2);
 	size = be32_to_cpu(*native_size);
 



On Fri, 2005-06-03 at 10:02 -0500, Kylene Jo Hall wrote:
> Hi Torsten,
> 
> I maintain the driver and am interested in figuring out what this
> problem is.  Can you please tell me what the device major/minor are
> on /dev/tpm.  Any output produced by the driver in /var/log/messages.
> Also the output of /sbin/lspci.  Also I am assuming you are using the
> version in the default 2.6.12-rc5.  There are many changes are in the -
> mm2 patch so I will pull down the default tree and make sure the version
> there is working.
> 
> Thanks,
> Kylie
> 
> On Fri, 2005-06-03 at 11:23 +0200, Torsten Landschoff wrote:
> > On Thu, 2005-06-02 at 15:00 -0700, trusted linux wrote:
> > > thanks, here is my strace related to tpm:
> > > 
> > > open("/dev/tpm", O_RDWR)                = -1 ENODEV
> > > (No such device)
> > > write(2, "Can\'t open TPM Driver\n", 22Can't open TPM
> > > Driver
> > > ) = 22
> > 
> > Okay, so the driver is in fact not working. It could be that /dev/tpm
> > has the wrong device number assigned. If the driver is really installed
> > can be checked by
> > 
> > 	systool -c misc|grep tpm
> > 
> > I bet it does not show anything. OTOH if the module loads successfully
> > it really should be there. No idea what's going wrong then. 
> > 
> > Which version of the driver are you using?
> > 
> > Greetings
> > 
> > 	Torsten
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> > 
> > 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
>