From: Daniel Walker <dwalker@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Esben Nielsen <simlo@phys.au.dk>,
Michal Schmidt <xschmi00@stud.feec.vutbr.cz>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [patch] Real-Time Preemption, -RT-2.6.12-rc6-V0.7.47-29
Date: Tue, 07 Jun 2005 13:31:30 -0700 [thread overview]
Message-ID: <1118176290.18629.29.camel@dhcp153.mvista.com> (raw)
In-Reply-To: <20050607194119.GA11185@elte.hu>
On Tue, 2005-06-07 at 21:41 +0200, Ingo Molnar wrote:
> ere are more microoptimizations to the spin_lock/unlock hotpath:
>
> - the caching of mutex_getprio() priority in p->normal_prio
>
> - the mutex lock/unlock paths are now all fall-through. (Found a gcc
> bug, it mishandles __builtin_expect() in certain cases and produces
> correct but suboptimal code - we are working it around now.)
>
> - reduced the amount of recursive preemption-counter bumps via the use
> of raw spinlocks
>
> - rely on the preemption-counter instead of IRQs-off sections
There is a local_irq_enable missing someplace in UP ..
BUG: scheduling with irqs disabled: khelper/0x00000000/5
caller is __down_mutex+0x276/0x440
[<c03a88d6>] __down_mutex+0x276/0x440 (4)
[<c03a75cc>] schedule+0xec/0x100 (4)
[<c03a88d6>] __down_mutex+0x276/0x440 (12)
[<c012b290>] remove_wait_queue+0x10/0x40 (64)
[<c0130e02>] __spin_lock+0x22/0x40 (32)
[<c012b290>] remove_wait_queue+0x10/0x40 (8)
[<c0130e8c>] _spin_lock_irqsave+0xc/0x20 (12)
[<c012b290>] remove_wait_queue+0x10/0x40 (8)
[<c012b290>] remove_wait_queue+0x10/0x40 (4)
[<c0126a2b>] worker_thread+0x14b/0x280 (20)
[<c01265a0>] __call_usermodehelper+0x0/0x60 (16)
[<c0112d20>] default_wake_function+0x0/0x40 (28)
[<c0112d20>] default_wake_function+0x0/0x40 (32)
[<c01268e0>] worker_thread+0x0/0x280 (36)
[<c012af24>] kthread+0x84/0xc0 (4)
[<c012aea0>] kthread+0x0/0xc0 (20)
[<c010132d>] kernel_thread_helper+0x5/0x18 (16)
next prev parent reply other threads:[~2005-06-07 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-07 19:41 Ingo Molnar
2005-06-07 20:31 ` Daniel Walker [this message]
2005-06-08 7:28 ` Ingo Molnar
2005-06-08 7:42 ` Ingo Molnar
2005-06-08 7:48 ` Ingo Molnar
2005-06-08 11:35 ` Gene Heskett
2005-06-08 11:59 ` Ingo Molnar
2005-06-08 14:54 ` Gene Heskett
2005-06-08 14:59 ` Ingo Molnar
2005-06-08 16:34 ` Gene Heskett
2005-06-08 15:44 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118176290.18629.29.camel@dhcp153.mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=simlo@phys.au.dk \
--cc=xschmi00@stud.feec.vutbr.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®