mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sven-Thorsten Dietrich <sdietrich@mvista.com>
To: Esben Nielsen <simlo@phys.au.dk>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Daniel Walker <dwalker@mvista.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] local_irq_disable removal
Date: Mon, 13 Jun 2005 01:05:05 -0700	[thread overview]
Message-ID: <1118649905.5729.76.camel@sdietrich-xp.vilm.net> (raw)
In-Reply-To: <Pine.OSF.4.05.10506130946010.10063-100000@da410.phys.au.dk>

On Mon, 2005-06-13 at 09:53 +0200, Esben Nielsen wrote:
> On Mon, 13 Jun 2005, Sven-Thorsten Dietrich wrote:
> > > 
> > 
> > Hi Esben,
> > 
> > I just wondered if you are talking about the scenario where an interrupt
> > is executing on one processor, and gets preempted. Then some code runs
> > on the same CPU, which does local_irq_disable (now preempt_disable), to
> > keep that IRQ from running, but the IRQ thread is already started?
> > 
> > In the community kernel, this could never happen, because IRQs can't be
> > preempted. But in RT, its possible an IRQ could be preempted, and under
> > some circumstance, this sequence could occur.
> > 
> > Is that is what you are talking about? If not, it might be over my head,
> > and I am sorry. If so, I think that scenario is covered under SMP.
> > 
> > Sven
> > 
> No, Sven it is not. I am not so worried about that scenario.
> I am worried about some coder somewhere still using local_irq_disable() -
> there is a lot of code out there doing that. We have not confirmed that
> all of it really locks small enough regions to preserver RT preemption.
> I for one is doubtfull about the cmos_lock thingy. (Sorry, can't connect
> to my machine at home to check where it is, right now.) A very weird setup
> with a kind of homebrewn spinlock.
> All these cases needs to be reviewed to see if it is valid to use a
> global lock type like local_irq_disable() or a local mutex must be used.
> The former is only "allowed" if the time being within the locked is
> deterministicly only in the order of the time for scheduling.
> I wanted to add a extra name to the namespace stating "this usage of
> local_irq_disable() have been reviwed wrt. RT_PREEMPT".

I am sure there are some issues like you describe out there.

I suppose we could examine each local_irq_disable, but I wonder if there
is not a better way.

I wrote earlier, that we could just keep specific IRQ threads from
runnning, rather than disabling preemption overall.

This is somewhat orthogonal, but would serve as a filter to break things
down into local_irq_disable to keep a specific IRQ from running, and
local_irq_disable to suppress all IRQ activity.

If we're going to walk trough all these local_irq_disables, we might as
well check-off that item as well.

What do you think?

Sven




  reply	other threads:[~2005-06-13  8:06 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-08  7:08 Daniel Walker
2005-06-08 11:21 ` Ingo Molnar
2005-06-08 20:33   ` Daniel Walker
2005-06-09 11:56     ` Ingo Molnar
2005-06-10 23:37 ` Esben Nielsen
2005-06-11  0:20   ` Daniel Walker
2005-06-11 13:13     ` Esben Nielsen
2005-06-11 13:46       ` Ingo Molnar
2005-06-11 14:32         ` Esben Nielsen
2005-06-11 16:36           ` Daniel Walker
2005-06-11 17:26             ` Thomas Gleixner
2005-06-11 18:40               ` Sven-Thorsten Dietrich
2005-06-12  0:07                 ` Thomas Gleixner
2005-06-12  0:15                   ` Sven-Thorsten Dietrich
2005-06-12  0:22                     ` Thomas Gleixner
2005-06-12  0:24                       ` Sven-Thorsten Dietrich
2005-06-11 19:16             ` Ingo Molnar
2005-06-11 19:34               ` Esben Nielsen
2005-06-11 19:44                 ` Sven-Thorsten Dietrich
2005-06-11 19:53                   ` Daniel Walker
2005-06-11 20:23                   ` Esben Nielsen
2005-06-11 22:59                     ` Sven-Thorsten Dietrich
2005-06-13  5:22                       ` Steven Rostedt
2005-06-13  6:20                         ` Sven-Thorsten Dietrich
2005-06-13 12:28                           ` Steven Rostedt
2005-06-11 20:03                 ` Ingo Molnar
2005-06-11 20:51                   ` Daniel Walker
2005-06-11 23:44                     ` Thomas Gleixner
2005-06-11 23:50                       ` Daniel Walker
2005-06-12  0:01                         ` Thomas Gleixner
2005-06-12  0:09                       ` Sven-Thorsten Dietrich
2005-06-12  0:28                         ` Thomas Gleixner
2005-06-12  1:05                         ` Gene Heskett
2005-06-13 12:03                           ` Paulo Marques
2005-06-13 12:19                             ` Esben Nielsen
2005-06-12  4:50                       ` cutaway
2005-06-12  6:57                       ` Ingo Molnar
2005-06-12 11:15                         ` Esben Nielsen
2005-06-12 11:52                           ` Ingo Molnar
2005-06-13  7:01                           ` Sven-Thorsten Dietrich
2005-06-13  7:53                             ` Esben Nielsen
2005-06-13  8:05                               ` Sven-Thorsten Dietrich [this message]
2005-06-13  8:54                                 ` Esben Nielsen
2005-06-13  9:13                                   ` Ingo Molnar
2005-06-12 15:28                         ` Daniel Walker
2005-06-12  4:31                     ` Karim Yaghmour
2005-06-12  4:32                       ` Daniel Walker
2005-06-12  4:56                         ` Karim Yaghmour
2005-06-12  4:55                           ` Daniel Walker
2005-06-12  5:16                             ` Karim Yaghmour
2005-06-12  5:14                               ` Daniel Walker
2005-06-12  5:27                                 ` Karim Yaghmour
2005-06-12 15:27                     ` Zwane Mwaikambo
2005-06-12 15:46                       ` Daniel Walker
2005-06-12 19:02                       ` Ingo Molnar
2005-06-12 17:02                     ` Andi Kleen
2005-06-13  7:08                   ` Sven-Thorsten Dietrich
2005-06-13  7:44                     ` Esben Nielsen
2005-06-13  7:53                       ` Sven-Thorsten Dietrich
2005-06-13  7:56                         ` Ingo Molnar
2005-06-13  7:47                     ` Ingo Molnar
2005-06-11 16:41           ` Sven-Thorsten Dietrich
2005-06-11 17:16             ` Esben Nielsen
2005-06-11 19:29               ` Sven-Thorsten Dietrich
2005-06-11 20:02               ` Sven-Thorsten Dietrich
2005-06-11 16:19         ` Daniel Walker
2005-06-11 13:51       ` Ingo Molnar
2005-06-11 15:00         ` Mika Penttilä
2005-06-11 16:45           ` Sven-Thorsten Dietrich
2005-06-11 16:53             ` Mika Penttilä
2005-06-11 17:13               ` Daniel Walker
2005-06-11 17:22                 ` Mika Penttilä
2005-06-11 17:25                   ` Daniel Walker
2005-06-11 17:29                     ` Mika Penttilä
2005-06-11 17:30                       ` Daniel Walker
2005-06-11 17:55                         ` Mika Penttilä
2005-06-11 16:28         ` Daniel Walker
2005-06-11 16:46           ` Esben Nielsen
2005-06-11 16:09       ` Daniel Walker
2005-06-11 16:31         ` Esben Nielsen
2005-06-11 16:51 ` Christoph Hellwig
2005-06-11 22:44   ` Ed Tomlinson
2005-06-12  6:23   ` Ingo Molnar
2005-06-12  9:28     ` Christoph Hellwig
2005-06-13  4:39       ` [RT] " Steven Rostedt
2005-06-16  5:35       ` Lee Revell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1118649905.5729.76.camel@sdietrich-xp.vilm.net \
    --to=sdietrich@mvista.com \
    --cc=dwalker@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=simlo@phys.au.dk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®