From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbbCICie (ORCPT ); Sun, 8 Mar 2015 22:38:34 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:37513 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbbCICid (ORCPT ); Sun, 8 Mar 2015 22:38:33 -0400 X-AuditID: cbfee6a1-f799b6d000003ba9-37-54fd079b8ab5 Date: Mon, 09 Mar 2015 02:38:19 +0000 (GMT) From: Yuan Zhong Subject: Re: Re: [f2fs-dev] [PATCH 1/3] f2fs:remove unnecessary condition judgment To: =?gb2312?Q?=3F=3F=3F?= Cc: Jaegeuk Kim , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" Reply-to: yuan.mark.zhong@samsung.com MIME-version: 1.0 X-MTR: 20150309023616353@yuan.mark.zhong Msgkey: 20150309023616353@yuan.mark.zhong X-EPLocale: zh_CN.gb2312 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150309023616353@yuan.mark.zhong X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=gb2312 MIME-version: 1.0 Message-id: <1119963205.1194691425868698614.JavaMail.weblogic@epmlwas01c> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t/tft3Z7H9DDE6e0rW4vGsOmwOjx+dN cgGMUVw2Kak5mWWpRfp2CVwZrx/MZSr4JlTx8YtdA+MWoS5GTg4hAS2J9z8eMncxcnBICJhI rDhaChKWEBCTuHBvPVsXIxdQyRxGiSPvLrGAJFgEVCRm3nrDDmKzCehL3Nm3jxHEFhYIkvj4 YiVYjQjQnM6VTxlBmpkF/jNK3NuxnRFkgZCAqsTxtWALeAUEJU7OfMICsUxD4trzBlaIuKbE 7yUXGCHukZBYdSkSooRXYkb7U6hyOYlpX9cwQ9jSEudnbWCEuXnx98dQcX6JY7d3MEHYAhJT zxyEqtGVuDvzMxuEzSexZuFbFpj6XaeWM8Psur9lLlSvhMTWlidgpzELKEpM6X7IDmFrScxr +M2E7hVeAU+JprWz2Scwys5CkpqFpH0WknZkNQsYWVYxiqYWJBcUJ6VXGOoVJ+YWl+al6yXn 525iBMfys4U7GL+ctz7EKMDBqMTDu+PEnxAh1sSy4srcQ4wSHMxKIryiJ4FCvCmJlVWpRfnx RaU5qcWHGKU5WJTEef+fyw0REkhPLEnNTk0tSC2CyTJxcEo1MC6xKdeY5L9VX0uyuOXvBK90 qz8CjKkfmy6dMDwxKaKeRX/h9y0783zenNSb2tJbr+RWdfD/M+aHt8ssr/6dXVBk/OxoXmny Jr5CU6u8N3Hmvjtyws9/K++NjPg7f0agtPy5RC7m2F/Get4G07mqupv8Zkj9LNh87hKH8bdj L9UCg3T7FfLYlViKMxINtZiLihMBVtoRwuECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t292cdDL005636 Hi Lee, >On Sat, Mar 07, 2015 at 10:05:25AM +0000, Yuan Zhong wrote: >> Remove the unnecessary condition judgment, because >> 'max_slots' has been initialized to '0' at the beginging >> of the function, as following: >> if (max_slots) >> max_len = 0; > >There is wrong statement. It should be fixed as *max_slot = 0. > >Thanks, Thanks for your review. it is my mistake.I will fix and resend the patch. > >> >> Signed-off-by: Yuan Zhong >> --- >> fs/f2fs/dir.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c >> index 590aeef..1f1a1bc 100644 >> --- a/fs/f2fs/dir.c >> +++ b/fs/f2fs/dir.c >> @@ -139,7 +139,7 @@ struct f2fs_dir_entry *find_target_dentry(struct qstr *name, int *max_slots, >> !memcmp(d->filename[bit_pos], name->name, name->len)) >> goto found; >> >> - if (max_slots && *max_slots >= 0 && max_len > *max_slots) { >> + if (max_slots && max_len > *max_slots) { >> *max_slots = max_len; >> max_len = 0; >> } >> -- >> 1.7.9.5 >> ------------------------------------------------------------------------------ >> Dive into the World of Parallel Programming The Go Parallel Website, sponsored >> by Intel and developed in partnership with Slashdot Media, is your hub for all >> things parallel software development, from weekly thought leadership blogs to >> news, videos, case studies, tutorials and more. Take a look and join the >> conversation now. http://goparallel.sourceforge.net/ >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I