From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77BB6CDB474 for ; Mon, 23 Oct 2023 11:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234439AbjJWLpC (ORCPT ); Mon, 23 Oct 2023 07:45:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234416AbjJWLow (ORCPT ); Mon, 23 Oct 2023 07:44:52 -0400 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09DC410C; Mon, 23 Oct 2023 04:44:47 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R641e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VuktnG._1698061482; Received: from 30.97.48.63(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VuktnG._1698061482) by smtp.aliyun-inc.com; Mon, 23 Oct 2023 19:44:43 +0800 Message-ID: <111bf8cf-48d5-6433-6343-92415b919f52@linux.alibaba.com> Date: Mon, 23 Oct 2023 19:44:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH V2 0/7] i2c: sprd: Modification of UNISOC Platform I2C Driver To: Huangzheng Lai , Andi Shyti Cc: Orson Zhai , Chunyan Zhang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, huangzheng lai , Xiongpeng Wu References: <20231023081158.10654-1-Huangzheng.Lai@unisoc.com> From: Baolin Wang In-Reply-To: <20231023081158.10654-1-Huangzheng.Lai@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2023 4:11 PM, Huangzheng Lai wrote: > Recently, some bugs have been discovered during use, patch3 and > patch5-6 are bug fixes. Also, this patchset add new features: > patch1 allows I2C to use more frequencies for communication, > patch2 allows I2C to use 'reset framework' for reset, and patch4 allows > I2C controller to dynamically switch frequencies during use. I suggest separating bugfix patches from feature patches to ensure that bugfix patches are reviewed and merged as soon as possible. > > change in V2 > -Using 'I2C' instead of 'IIC' in the patch set. > -Using imperative form in patch subject. > -Use 'switch case' instead of 'else if' in PATCH 1/7. > -Modify if (i2c_dev->rst != NULL) to if (i2c_dev->rst) in PATCH 2/7. > -Modify some dev_err() to dev_warn() or dev_dbg(). > -Clear i2c_dev->ack_flag in sprd_i2c_clear_ack() in PATCH 3/7. > -Modify the indentation format of the code in PATCH 4/7. > -Move sprd_i2c_enable() above its caller in PATCH 5/7. > -Remove 'Set I2C_RX_ACK when clear irq' commit. > -Add Fixes tags. > > Huangzheng Lai (7): > i2c: sprd: Add configurations that support 1Mhz and 3.4Mhz frequencies > i2c: sprd: Add I2C driver to use 'reset framework' function > i2c: sprd: Use global variables to record I2C ack/nack status instead > of local variables > i2c: sprd: Add I2C controller driver to support dynamic switching of > 400K/1M/3.4M frequency > i2c: sprd: Configure the enable bit of the I2C controller before each > transmission initiation > i2c: sprd: Increase the waiting time for I2C transmission to avoid > system crash issues > i2c: sprd: Add I2C_NACK_EN and I2C_TRANS_EN control bits > > drivers/i2c/busses/i2c-sprd.c | 166 ++++++++++++++++++++++------------ > 1 file changed, 106 insertions(+), 60 deletions(-) >