Re: [PATCH v18 12/13] dt-bindings: mediatek: Add MT8196 JPEG SMMU bindings

["Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>]

On Mon, 2026-10-12 at 11:31 +0200, Krzysztof Kozlowski wrote:
> On Sat, Oct 10, 2026 at 04:07:16PM +0800, Kyrie Wu wrote:
> > Document the decoder and encoder phandles and describe the
> > dedicated
> > JPEG SMMU configuration syscon for MT8196.
> > 
> > Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
> > ---
> >  .../media/mediatek,mt8195-jpegdec.yaml        | 16 ++++++++
> >  .../media/mediatek,mt8195-jpegenc.yaml        | 16 ++++++++
> >  .../mediatek/mediatek,mt8196-jpeg-smmu.yaml   | 41
> > +++++++++++++++++++
> >  MAINTAINERS                                   |  2 +
> >  4 files changed, 75 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/soc/mediatek/mediatek,mt8196-
> > jpeg-smmu.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > index 28a9a9b..b1dccc3 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > @@ -73,6 +73,22 @@ patternProperties:
> >        power-domains:
> >          maxItems: 1
> >  
> > +      mediatek,smmu-config:
> > +        $ref: /schemas/types.yaml#/definitions/phandle
> > +        description:
> > +          Phandle to the MT8196 JPEG SMMU configuration syscon
> > used to
> > +          program this decoder's GUSER_ID fields.
> > +
> > +    allOf:
> > +      - if:
> > +          properties:
> > +            compatible:
> > +              contains:
> > +                const: mediatek,mt8196-jpgdec-hw
> > +        then:
> > +          required:
> > +            - mediatek,smmu-config
> 
> Why are you adding incomplete hardware in one patch and then
> immediately
> fixing it later?
> 
> Please read writing bindings doc (and part about complete hardware
> support).
> 
> Best regards,
> Krzysztof
> 
Hi Krzysztof,

You are right. The MT8196 decoder and encoder compatibles should not be
introduced before their schemas contain all properties and constraints
required to describe the hardware.

In v19, I will introduce the shared JPEG SMMU syscon schema first. I
will then fold the mediatek,smmu-config property and its required
constraint into the decoder-compatible patch, and do the same for the
encoder patch.

This will make each compatible-introduction commit complete on its own,
instead of fixing an incomplete binding in a later patch.

Thank you for the review.

Best regards,
Kyrie