From: Michael Ellerman <michael@ellerman.id.au>
To: linuxppc64-dev@ozlabs.org, netdev@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/12] iseries_veth: Make error messages more user friendly, and add a debug macro
Date: Thu, 30 Jun 2005 20:20:39 +1000 [thread overview]
Message-ID: <1120126839.106943.128468321759.qpatch@concordia> (raw)
In-Reply-To: <200506302016.55125.michael@ellerman.id.au>
Currently the iseries_veth driver prints the file name and line number in its
error messages. This isn't very useful for most users, so just print
"iseries_veth: message" instead.
Also add a veth_debug() and veth_info() macro to replace the current
veth_printk().
---
drivers/net/iseries_veth.c | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)
Index: veth-dev/drivers/net/iseries_veth.c
===================================================================
--- veth-dev.orig/drivers/net/iseries_veth.c
+++ veth-dev/drivers/net/iseries_veth.c
@@ -79,6 +79,8 @@
#include <asm/iommu.h>
#include <asm/vio.h>
+#define DEBUG 1
+
#include "iseries_veth.h"
MODULE_AUTHOR("Kyle Lucke <klucke@us.ibm.com>");
@@ -176,11 +178,18 @@ static void veth_timed_ack(unsigned long
* Utility functions
*/
-#define veth_printk(prio, fmt, args...) \
- printk(prio "%s: " fmt, __FILE__, ## args)
+#define veth_info(fmt, args...) \
+ printk(KERN_INFO "iseries_veth: " fmt, ## args)
#define veth_error(fmt, args...) \
- printk(KERN_ERR "(%s:%3.3d) ERROR: " fmt, __FILE__, __LINE__ , ## args)
+ printk(KERN_ERR "iseries_veth: Error: " fmt, ## args)
+
+#ifdef DEBUG
+#define veth_debug(fmt, args...) \
+ printk(KERN_DEBUG "iseries_veth: " fmt, ## args)
+#else
+#define veth_debug(fmt, args...) do {} while (0)
+#endif
static inline void veth_stack_push(struct veth_lpar_connection *cnx,
struct veth_msg *msg)
next prev parent reply other threads:[~2005-06-30 10:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-30 10:16 [RFC/PATCH 0/12] Updates & bug fixes for iseries_veth network driver Michael Ellerman
2005-06-30 10:20 ` [PATCH 3/12] iseries_veth: Make init_connection() & destroy_connection() symmetrical Michael Ellerman
2005-06-30 10:20 ` [PATCH 5/12] iseries_veth: Try to avoid pathological reset behaviour Michael Ellerman
2005-06-30 10:20 ` [PATCH 6/12] iseries_veth: Fix broken promiscuous handling Michael Ellerman
2005-06-30 10:20 ` [PATCH 8/12] iseries_veth: Replace lock-protected atomic with an ordinary variable Michael Ellerman
2005-06-30 10:20 ` [PATCH 7/12] iseries_veth: Remove redundant message stack lock Michael Ellerman
2005-06-30 10:20 ` [PATCH 9/12] iseries_veth: Use ref counts to track lifecycle of connection structs Michael Ellerman
2005-06-30 10:20 ` Michael Ellerman [this message]
2005-06-30 10:20 ` [PATCH 4/12] iseries_veth: Remove a FIXME WRT deletion of the ack_timer Michael Ellerman
2005-06-30 10:20 ` [PATCH 10/12] iseries_veth: Remove TX timeout code Michael Ellerman
2005-06-30 10:20 ` [PATCH 2/12] iseries_veth: Cleanup error and debug messages Michael Ellerman
2005-06-30 10:20 ` [PATCH 12/12] iseries_veth: Simplify full-queue handling Michael Ellerman
2005-06-30 10:20 ` [PATCH 11/12] iseries_veth: Add a per-connection ack timer Michael Ellerman
2005-06-30 14:41 ` [RFC/PATCH 0/12] Updates & bug fixes for iseries_veth network driver Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120126839.106943.128468321759.qpatch@concordia \
--to=michael@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®