From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261211AbVGDOmP (ORCPT ); Mon, 4 Jul 2005 10:42:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261167AbVGDOmP (ORCPT ); Mon, 4 Jul 2005 10:42:15 -0400 Received: from ppsw-0.csi.cam.ac.uk ([131.111.8.130]:23731 "EHLO ppsw-0.csi.cam.ac.uk") by vger.kernel.org with ESMTP id S261211AbVGDOjS (ORCPT ); Mon, 4 Jul 2005 10:39:18 -0400 X-Cam-SpamDetails: Not scanned X-Cam-AntiVirus: No virus found X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Subject: Re: Problem with inotify From: Anton Altaparmakov To: Daniel Drake Cc: David =?ISO-8859-1?Q?G=F3mez?= , Robert Love , John McCutchan , Linux-kernel In-Reply-To: <1120487242.11399.5.camel@imp.csi.cam.ac.uk> References: <20050630181824.GA1058@fargo> <1120156188.6745.103.camel@betsy> <20050630193320.GA1136@fargo> <20050630204832.GA3854@fargo> <42C65A8B.9060705@gentoo.org> <42C72563.7040103@gentoo.org> <42C7BF37.9010005@gentoo.org> <1120487242.11399.5.camel@imp.csi.cam.ac.uk> Content-Type: text/plain Organization: Computing Service, University of Cambridge, UK Date: Mon, 04 Jul 2005 15:39:08 +0100 Message-Id: <1120487948.11399.7.camel@imp.csi.cam.ac.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2005-07-04 at 15:27 +0100, Anton Altaparmakov wrote: > On Sun, 2005-07-03 at 11:34 +0100, Daniel Drake wrote: > > I reverted the patch you sent earlier > > (inotify_unmount_inodes-list-iteration-fix.diff) and applied the one you > > attached here (inotify_unmount_inodes-list-iteration-fix2.diff). > > > > The good news is that the hang is gone. The bad news is that you cured the > > hang by introducing an oops :( > > )-: I have addressed the only things I can think off that could cause > the oops and below is the resulting patch. Could you please test it? I forgot to say that this patch is a replacement for the previous (inotify_unmount_inodes-list-iteration-fix{,2}.diff}. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/