mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve French <smfltc@us.ibm.com>
To: linux-kernel@vger.kernel.org, rml@novell.com
Subject: supporting functions missing from inotify patch
Date: 13 Jul 2005 13:43:32 -0500	[thread overview]
Message-ID: <1121280212.5544.46.camel@stevef95.austin.ibm.com> (raw)

It looks like a couple of exports and a key supporting function are
missing from the inotify patch that went into mainline yesterday.

I don't see an inode operation for registering inotify events in the fs
(there is a file operation for dir_notify to register its events).  In
create_watch in fs/inotify.c I expected to see something like:

if(inode->inotify_create)
	ret = inode->inotify_create(inode, mask);

(a similar change would be needed in the INOTIFY_IGNORE path)

Without this, inotify will be broken except on local filesystems.
Cluster and network filesystems (nfs, cifs etc.) won't know when they
need to start calling back on remote directory change notifications if
they aren't called at the time of the ioctl(INOTIFY_WATCH)

I also don't see exports for 
	fsnotify_access
	fsnotify_modify

Without these exports, network and cluster filesystems can't notify the
local system about changes.

Tracking local changes to files/directories is somewhat useful by itself
on non-networked systems.  But if directory and file change notification
for remote/cluster filesystems is broken that limits its usefullness a
lot.


             reply	other threads:[~2005-07-13 18:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-13 18:43 Steve French [this message]
2005-07-13 19:12 ` Robert Love
2005-07-13 20:21 Steve French
2005-07-13 20:39 ` Robert Love
2005-07-13 21:51 ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1121280212.5544.46.camel@stevef95.austin.ibm.com \
    --to=smfltc@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rml@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®