mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	 PDx86 <platform-driver-x86@vger.kernel.org>,
	 Hans de Goede <hansg@kernel.org>,
	Andy Shevchenko <andy@kernel.org>,  Armin Wolf <W_Armin@gmx.de>
Subject: Re: [GIT PULL] platform-drivers-x86 for v7.4-1
Date: Wed, 28 Oct 2026 21:25:56 +0200 (EET)	[thread overview]
Message-ID: <112173bf-15bb-5a6f-e3d9-73c7675de537@linux.intel.com> (raw)
In-Reply-To: <CAHk-=wjk2f+Vu656fEa7FOyHHaFe+-M-GEwUQPXykaYoor6A7g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2448 bytes --]

On Wed, 28 Oct 2026, Linus Torvalds wrote:

> On Tue, 27 Oct 2026 at 23:59, Ilpo Järvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
> >
> > Highlights:
> 
> Please, people - give a *summary*.
> 
> Not 150 lines that just re-organizes the shortlog with some editing.
> 
> It's not a "Highlight" if it just repeats every small detail. That's
> just a "list". And it certainly isn't informative.
> 
> I - and others who read merge commits - want to know the big picture.
> Not every driver detail. If I wanted to know the exact details of what
> happened in some particular driver, I would be reading the commits for
> that driver. That's not what the merge is about. The merge is about
> bigger issues than to see things like this:
> 
>     - intel/pmt:
>        - Block mmap when read_telem() callback is present
> 
> and that's just one example of a *lot* of "this is not a big picture
> issue, it's a small detail in one particular driver".
> 
> I suspect one thing that is actually a "bigger picture" issue is that
> 
>  - ACPI: video: Remove CONFIG_X86 dependency as WMI now supports non-X86
>                archs
> 
> which is something that people might find interesting in general.
> 
> On the whole, I think 90% of that list should have been written along
> the lines of
> 
>  "Usual updates for laptop quirks from HP, ASUS, Acer and Dell:
>     - new model names and recent CPU support
>     - more special button / function key handling
>     - battery and hardware monitoring quirks"
> 
> or something.
> 
> Please *help* me write usable merge messages that are actually
> informative and not just a "data dump". For the data dump, we have the
> details in the git history.

Okay, thanks for the feedback. I'll try to leave more out the next time
and/or write it more directly to you specifically.

So far I've mainly written these from the perspective if one has the 
relevant HW or is using a driver, whether the change might be of interest 
to such an user or not (it certainly didn't have everything even if I 
can believe you can easily get that feeling).

I understand in platform drivers case many of those changes would be of 
zero interested to you, and same could be said of anyone else. HP owner 
won't be interested in any Dell changes, nor even those HP changes not 
relevant for one's device, etc.

...But I don't *have to* keep doing it like that. :-)

-- 
 i.

  reply	other threads:[~2026-10-28 19:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28  9:34 Ilpo Järvinen
2026-10-28 18:07 ` Linus Torvalds
2026-10-28 19:25   ` Ilpo Järvinen [this message]
2026-10-28 19:36     ` Linus Torvalds
2026-10-28 22:46       ` Jonathan Corbet
2026-10-28 18:10 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=112173bf-15bb-5a6f-e3d9-73c7675de537@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=andy@kernel.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®