Re: [PATCH] jsm driver - Linux-2.6.12.3

["V. ANANDA KRISHNAN" <mansarov@us.ibm.com>]

I am using RHEL4.0-U1 as the distro. Here is the info on gcc version is
3.4.3-22.1

Thanks for your feed-back.

Ananda Krishnan
On Tue, 2005-07-19 at 22:47 +0400, Alexey Dobriyan wrote:
> On Tue, Jul 19, 2005 at 12:53:20PM -0500, V. ANANDA KRISHNAN wrote:
> > This patch takes care of (1) compiler warnings which displays the mixing
> > of declarations and code
> 
> With what gcc version and what CFLAGS?
> 
> > (2) dynamic allocation of major device number
> > instead of the static number 253 (3) the version update to reflect the
> > changes in the patch.
> 
> > --- linux-2.6.12.3.orig/drivers/serial/jsm/jsm_driver.c
> > +++ linux-2.6.12.3.new/drivers/serial/jsm/jsm_driver.c
> 
> > + * CHANGE LOG:
> > + * Jul 18, 2005: Changed the major number changed to 0 to use the dynamic
> > + *	allocation of major number by OS.
> > + *
> 
> ChangeLog maintenance is the job of SCM. Don't add useless comments.
> 
> > --- linux-2.6.12.3.orig/drivers/serial/jsm/jsm_neo.c
> > +++ linux-2.6.12.3.new/drivers/serial/jsm/jsm_neo.c
> 
> > -	u8 ier = readb(&ch->ch_neo_uart->ier);
> > -	u8 efr = readb(&ch->ch_neo_uart->efr);
> > +	u8 ier, efr;
> > +	ier = readb(&ch->ch_neo_uart->ier);
> > +	efr = readb(&ch->ch_neo_uart->efr);
> 
>