From: Bernd Petrovitsch <bernd@firmix.at>
To: Miles Bader <miles@gnu.org>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v850: const-qualify first parameter of find_next_zero_bit
Date: Wed, 20 Jul 2005 10:46:07 +0200 [thread overview]
Message-ID: <1121849167.12525.12.camel@tara.firmix.at> (raw)
In-Reply-To: <20050720083830.5941F43F@mctpc71>
On Wed, 2005-07-20 at 17:38 +0900, Miles Bader wrote:
[...]
> @@ -157,7 +157,7 @@
> #define find_first_zero_bit(addr, size) \
> find_next_zero_bit ((addr), (size), 0)
>
> -extern __inline__ int find_next_zero_bit (void *addr, int size, int offset)
> +extern __inline__ int find_next_zero_bit(const void *addr, int size, int offset)
> {
> unsigned long *p = ((unsigned long *) addr) + (offset >> 5);
Why not const-qualify *p and the cast also (avoiding warnings and
actually making the change complete)?
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
prev parent reply other threads:[~2005-07-20 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-20 8:38 Miles Bader
2005-07-20 8:46 ` Bernd Petrovitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121849167.12525.12.camel@tara.firmix.at \
--to=bernd@firmix.at \
--cc=linux-kernel@vger.kernel.org \
--cc=miles@gnu.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®