From: Andrew Lunn <andrew@lunn.ch>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Mark Brown <broonie@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
Dent Project <dentproject@linuxfoundation.org>
Subject: Re: [PATCH net-next v4 05/17] net: pse-pd: Introduce PSE types enumeration
Date: Mon, 19 Feb 2024 16:44:34 +0100 [thread overview]
Message-ID: <11225a0d-bdc4-459c-9258-c9da217cc89e@lunn.ch> (raw)
In-Reply-To: <20240219160456.0b5e8de3@kmaincent-XPS-13-7390>
On Mon, Feb 19, 2024 at 04:04:56PM +0100, Köry Maincent wrote:
> On Fri, 16 Feb 2024 17:36:38 -0800
> Jakub Kicinski <kuba@kernel.org> wrote:
> > > > but why the separate header? Is it going to be used in other parts of
> > > > uAPI than just in ethtool?
> > >
> > > We might use it in pse core if capabilities between PoE and PoDL differ but
> > > I am not sure about it.
> > > Do you prefer to move it to ethtool header and add prefix ETHTOOL_ to the
> > > enum values?
> >
> > I don't know enough to have an opinion :) Whatever you end up doing,
> > it's probably worth documenting the reason for the choice in the commit
> > message?
>
> Mmh, I am still not sure of the best choice on this. I think I will move it to
> ethtool as you suggested.
kAPI is hard to change. So it is worth thinking about it.
Can you think of any possible kAPI not using ethtool netlink? Its not
going to be ioctl. We generally don't export new things in /sysfs if
we have netlink, etc.
So to me, it is only going to be used be the ethtool API, so i would
follow the usual conventions for ethtool.
Andrew
next prev parent reply other threads:[~2024-02-19 15:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 16:02 [PATCH net-next v4 00/17] net: Add support for Power over Ethernet (PoE) Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 01/17] MAINTAINERS: net: Add Oleksij to pse-pd maintainers Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 02/17] of: property: Add fw_devlink support for pse parent Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 03/17] net: pse-pd: Rectify and adapt the naming of admin_cotrol member of struct pse_control_config Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 04/17] ethtool: Expand Ethernet Power Equipment with c33 (PoE) alongside PoDL Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 05/17] net: pse-pd: Introduce PSE types enumeration Kory Maincent
2024-02-15 18:58 ` Jakub Kicinski
2024-02-16 9:42 ` Köry Maincent
2024-02-17 1:36 ` Jakub Kicinski
2024-02-19 15:04 ` Köry Maincent
2024-02-19 15:44 ` Andrew Lunn [this message]
2024-02-21 14:40 ` Köry Maincent
2024-02-21 14:36 ` Rob Herring
2024-02-15 16:02 ` [PATCH net-next v4 06/17] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 07/17] netlink: specs: Modify pse attribute prefix Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 08/17] netlink: specs: Expand the pse netlink command with PoE interface Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 09/17] MAINTAINERS: Add myself to pse networking maintainer Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 10/17] net: pse-pd: Add support for PSE PIs Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 11/17] dt-bindings: net: pse-pd: Add another way of describing several " Kory Maincent
2024-02-15 18:46 ` Rob Herring
2024-02-16 8:56 ` Köry Maincent
2024-02-16 8:58 ` Köry Maincent
2024-02-16 2:16 ` Rob Herring
2024-02-17 14:01 ` Krzysztof Kozlowski
2024-02-19 9:22 ` Köry Maincent
2024-02-15 16:02 ` [PATCH net-next v4 12/17] net: pse-pd: Add support for setup_pi_matrix callback Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 13/17] net: pse-pd: Use regulator framework within PSE framework Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 14/17] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller Kory Maincent
2024-02-17 12:14 ` Oleksij Rempel
2024-02-19 14:38 ` Köry Maincent
2024-02-19 14:54 ` Andrew Lunn
2024-02-20 10:40 ` Köry Maincent
2024-02-20 11:05 ` Oleksij Rempel
2024-02-21 14:41 ` Rob Herring
2024-02-21 15:06 ` Oleksij Rempel
2024-02-17 14:03 ` Krzysztof Kozlowski
2024-02-15 16:02 ` [PATCH net-next v4 15/17] net: pse-pd: Add PD692x0 PSE controller driver Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 16/17] dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller Kory Maincent
2024-02-15 16:02 ` [PATCH net-next v4 17/17] net: pse-pd: Add TI TPS23881 PSE controller driver Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11225a0d-bdc4-459c-9258-c9da217cc89e@lunn.ch \
--to=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=russ.weight@linux.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®