From: Daniel Walker <dwalker@mvista.com>
To: yang.yi@bmrtech.com
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch]: latency histogram patch cleanup
Date: Wed, 10 Aug 2005 19:01:04 -0700 [thread overview]
Message-ID: <1123725664.8187.24.camel@dhcp153.mvista.com> (raw)
In-Reply-To: <1123753388.4092.173.camel@montavista2>
Comments below ...
On Thu, 2005-08-11 at 09:43 +0000, yangyi wrote:
> +#ifndef CONFIG_CRITICAL_LATENCY_HIST
> if (!report_latency(delta))
> goto out;
> +#endif
Why ? This combined with the hunk below is just preempt_threshold ..
Just use preempt_threshold instead of all the ifdefs everywhere .
> ____trace(cpu, TRACE_FN, tr, CALLER_ADDR0, parent_eip, 0, 0, 0);
> /*
> @@ -1393,11 +1382,13 @@ check_critical_timing(int cpu, struct cp
> if (tr->critical_sequence != max_sequence || down_trylock(&max_mutex))
> goto out;
>
> +#ifndef CONFIG_CRITICAL_LATENCY_HIST
> if (!preempt_thresh && preempt_max_latency > delta) {
> printk("bug: updating %016Lx > %016Lx?\n",
> preempt_max_latency, delta);
> printk(" [%016Lx %016Lx %016Lx]\n", T0, T1, T2);
> }
> +#endif
>
> latency = cycles_to_usecs(delta);
>
next prev parent reply other threads:[~2005-08-11 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 9:43 yangyi
2005-08-11 2:01 ` Daniel Walker [this message]
2005-08-11 11:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123725664.8187.24.camel@dhcp153.mvista.com \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yang.yi@bmrtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®