From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-parport@lists.infradead.org
Subject: Re: [BUG] PLIP: Badness in enable_irq and Oops
Date: Sun, 14 Aug 2005 02:00:10 +0100 [thread overview]
Message-ID: <1123981210.14138.32.camel@localhost.localdomain> (raw)
In-Reply-To: <42FE8DD2.10204@gmail.com>
On Sul, 2005-08-14 at 02:18 +0200, Jiri Slaby wrote:
> I founded out, that in plip_error (drivers/plip.c)
> ENABLE(dev->irq);
> is called by before not calling
> DISABLE(dev->irq);
> in plip_bh_timeout_error in
It used to be valid to call enable/disable indiscriminately.
> if (error == HS_TIMEOUT) { ...
> My opinion is, that ENABLE in plip_error should be called only if the
> error was HS_TIMEOUT too.
Tracking the state would fix it yes
> That was badness. And what about the oops:
> case PLIP_PK_DONE:
> /* Inform the upper layer for the arrival of a packet. */
> rcv->skb->protocol=plip_type_trans(rcv->skb, dev); <----
> the skb here is NULL
> netif_rx(rcv->skb);
> Should we inform somebody, if skb is NULL?
You should never get to PK_DONE with rcv->skb = NULL as if that is the
case you are not done. Its years since I looked at plip.
prev parent reply other threads:[~2005-08-14 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-14 0:18 Jiri Slaby
2005-08-14 1:00 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1123981210.14138.32.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®