From: Steven Rostedt <rostedt@goodmis.org>
To: Valentin Rabinovich <vrabin@cs.joensuu.fi>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: mmap_kmem()
Date: Thu, 18 Aug 2005 08:34:09 -0400 [thread overview]
Message-ID: <1124368449.5186.38.camel@localhost.localdomain> (raw)
In-Reply-To: <1124355224.43044c984be40@wwwmail.joensuu.fi>
On Thu, 2005-08-18 at 11:53 +0300, Valentin Rabinovich wrote:
> Bug in mmap_kmem(), drivers/char/mem.c.
> When mapping the kmem, page alingning seems to mess the address:
>
> unsigned long long val;
> val = (u64)vma->vm_pgoff << PAGE_SHIFT;
> vma->vm_pgoff = ((unsigned long)val >> PAGE_SHIFT) - PAGE_OFFSET;
> vma->vm_pgoff = __pa(val) >> PAGE_SHIFT;
>
> Subtracting 0xc0000000 and shifting is made in wrong order.
> Kernel: 2.6.12.3, 2.6.12.4
This is already fixed in 2.6.13-rc6-git9, so you need to wait for it in
the 2.6.13 release, or better yet, download and test the git release.
-- Steve
prev parent reply other threads:[~2005-08-18 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-18 8:53 Valentin Rabinovich
2005-08-18 12:34 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124368449.5186.38.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vrabin@cs.joensuu.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®