From: Steven Rostedt <rostedt@goodmis.org>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [QUESTION] Why isn't there a unregister_die_notifier?
Date: Thu, 18 Aug 2005 12:52:09 -0400 [thread overview]
Message-ID: <1124383929.5186.69.camel@localhost.localdomain> (raw)
In-Reply-To: <p73br3vtdc4.fsf@verdi.suse.de>
On Thu, 2005-08-18 at 18:32 +0200, Andi Kleen wrote:
> Steven Rostedt <rostedt@goodmis.org> writes:
>
> > Hi, I have a debugging module that I want to register a die notifier.
> > But I just noticed that I can't unregister it. So for now I either just
> > keep the module loaded and never unloaded it, compile it into the
> > kernel, or ifdef out the register_die_notifier when loaded as a module.
> >
> > Is there some reason that there isn't such a call, or maybe there is,
> > and I don't see it (called something else). Or is this something that
> > should be added?
>
> I didn't add one original because unloading debuggers is very tricky.
> There is no locking and no reference counting and they can be entered
> in any context. Adding it would require some RCU tricks at least and
> might still have some non trivial races.
Yeah, I use macros to call all the debugger code and spinlocks to
protect them. The macros change when the module is built into the kernel
to not do any protection, since it isn't needed. It's not the most
efficient thing, and RCU would probably be better. But I can insert and
remove this module over and over with the debugging going on, and it
hasn't broke yet. But I guess, I'll just do without for now.
-- Steve
next prev parent reply other threads:[~2005-08-18 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1124377142.5186.45.camel@localhost.localdomain.suse.lists.linux.kernel>
2005-08-18 16:32 ` Andi Kleen
2005-08-18 16:52 ` Steven Rostedt [this message]
2005-08-18 14:59 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1124383929.5186.69.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome