mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: David Teigland <teigland@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, akpm@osdl.org,
	linux-kernel@vger.kernel.org, linux-cluster@redhat.com
Subject: Re: GFS, what's remaining
Date: Thu, 01 Sep 2005 13:35:23 +0200	[thread overview]
Message-ID: <1125574523.5025.10.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20050901104620.GA22482@redhat.com>

On Thu, 2005-09-01 at 18:46 +0800, David Teigland wrote:
> Hi, this is the latest set of gfs patches, it includes some minor munging
> since the previous set.  Andrew, could this be added to -mm? there's not
> much in the way of pending changes.
> 
> http://redhat.com/~teigland/gfs2/20050901/gfs2-full.patch
> http://redhat.com/~teigland/gfs2/20050901/broken-out/

+static inline void glock_put(struct gfs2_glock *gl)
+{
+	if (atomic_read(&gl->gl_count) == 1)
+		gfs2_glock_schedule_for_reclaim(gl);
+	gfs2_assert(gl->gl_sbd, atomic_read(&gl->gl_count) > 0,);
+	atomic_dec(&gl->gl_count);
+}

this code has a race

what is gfs2_assert() about anyway? please just use BUG_ON directly everywhere

+static inline int queue_empty(struct gfs2_glock *gl, struct list_head *head)
+{
+	int empty;
+	spin_lock(&gl->gl_spin);
+	empty = list_empty(head);
+	spin_unlock(&gl->gl_spin);
+	return empty;
+}

that looks like a racey interface to me... if so.. why bother locking at all?
+void gfs2_glock_hold(struct gfs2_glock *gl)
+{
+	glock_hold(gl);
+}

eh why?

+struct gfs2_holder *gfs2_holder_get(struct gfs2_glock *gl, unsigned int state,
+				    int flags, int gfp_flags)
+{
+	struct gfs2_holder *gh;
+
+	gh = kmalloc(sizeof(struct gfs2_holder), GFP_KERNEL | gfp_flags);

this looks odd. Either you take flags or you don't.. this looks really half arsed and thus is really surprising 
to all callers


static int gi_skeleton(struct gfs2_inode *ip, struct gfs2_ioctl *gi,
+		       gi_filler_t filler)
+{
+	unsigned int size = gfs2_tune_get(ip->i_sbd, gt_lockdump_size);
+	char *buf;
+	unsigned int count = 0;
+	int error;
+
+	if (size > gi->gi_size)
+		size = gi->gi_size;
+
+	buf = kmalloc(size, GFP_KERNEL);
+	if (!buf)
+		return -ENOMEM;
+
+	error = filler(ip, gi, buf, size, &count);
+	if (error)
+		goto out;
+
+	if (copy_to_user(gi->gi_data, buf, count + 1))
+		error = -EFAULT;

where does count get a sensible value?

+static unsigned int handle_roll(atomic_t *a)
+{
+	int x = atomic_read(a);
+	if (x < 0) {
+		atomic_set(a, 0);
+		return 0;
+	}
+	return (unsigned int)x;
+}

this is just plain scary.


you'll have to post the rest of your patches if you want anyone to look at them...




  parent reply	other threads:[~2005-09-01 11:35 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-01 10:46 David Teigland
2005-09-01 10:42 ` Arjan van de Ven
2005-09-01 10:59 ` Andrew Morton
2005-09-01 14:49   ` Alan Cox
2005-09-01 14:27     ` Christoph Hellwig
2005-09-01 15:28       ` Alan Cox
2005-09-01 15:11         ` Lars Marowsky-Bree
2005-09-01 17:56         ` Christoph Hellwig
2005-09-02  7:04           ` David Teigland
2005-09-01 17:23     ` Daniel Phillips
2005-09-01 20:21     ` Andrew Morton
2005-09-02 21:17       ` Andi Kleen
2005-09-02 23:03         ` Bryan Henderson
2005-09-03  0:16         ` Mark Fasheh
2005-09-03  6:42           ` Daniel Phillips
2005-09-03  6:46             ` [Linux-cluster] " Wim Coekaerts
2005-09-03 22:21               ` Daniel Phillips
2005-09-04  1:09                 ` Joel Becker
2005-09-04  1:32                   ` Andrew Morton
2005-09-04  3:06                     ` Joel Becker
2005-09-04  4:22                       ` Daniel Phillips
2005-09-04  4:30                         ` Joel Becker
2005-09-04  4:51                           ` Daniel Phillips
2005-09-04  5:00                             ` Joel Becker
2005-09-04  5:52                               ` Daniel Phillips
2005-09-04  5:56                                 ` Joel Becker
2005-09-04  4:46                         ` Andrew Morton
2005-09-04  4:58                           ` Joel Becker
2005-09-04  5:41                             ` Andrew Morton
2005-09-04  5:49                               ` Joel Becker
2005-09-05  4:30                               ` David Teigland
2005-09-05  8:54                                 ` Andrew Morton
2005-09-05  9:24                                   ` David Teigland
2005-09-05  9:19                                     ` Andrew Morton
2005-09-05  9:30                                       ` Daniel Phillips
2005-09-05  9:48                                       ` David Teigland
2005-09-05 12:21                                       ` Alan Cox
2005-09-05 19:53                                         ` Andrew Morton
2005-09-05 23:20                                           ` Alan Cox
2005-09-05 23:06                                             ` Andrew Morton
2005-09-14  9:01                                         ` Patrick Caulfield
2005-09-14  9:46                                           ` Antonio Vargas
2005-09-05 19:11                                     ` kurt.hackel
2005-09-04  6:10                           ` Mark Fasheh
2005-09-04  7:23                             ` Andrew Morton
2005-09-04  8:17                               ` Mark Fasheh
2005-09-04  8:37                                 ` Andrew Morton
2005-09-04  6:40                           ` Daniel Phillips
2005-09-04  7:28                             ` Andrew Morton
2005-09-04  8:01                               ` Joel Becker
2005-09-04  8:18                                 ` Andrew Morton
2005-09-04  9:11                                   ` Joel Becker
2005-09-04  9:18                                     ` Andrew Morton
2005-09-04  9:39                                       ` Joel Becker
2005-09-04 18:03                                     ` Hua Zhong
2005-09-04 19:51                               ` Daniel Phillips
2005-09-04  8:37                           ` Alan Cox
2005-09-05 23:32                             ` Joel Becker
2005-09-03  5:57         ` Daniel Phillips
2005-09-05 14:14           ` Lars Marowsky-Bree
2005-09-05 15:49             ` Daniel Phillips
2005-09-05 16:18               ` Dmitry Torokhov
2005-09-06  0:57                 ` Daniel Phillips
2005-09-06  2:03                   ` Dmitry Torokhov
2005-09-06  4:02                     ` Daniel Phillips
2005-09-06  4:07                       ` GFS, what's remainingh Dmitry Torokhov
2005-09-06  4:58                         ` Daniel Phillips
2005-09-06  5:05                           ` Dmitry Torokhov
2005-09-06  6:48                             ` Daniel Phillips
2005-09-06  6:55                               ` Dmitry Torokhov
2005-09-06  7:18                                 ` Daniel Phillips
2005-09-06 14:31                                   ` Dmitry Torokhov
2005-09-06 13:42                               ` Alan Cox
2005-09-03  7:06         ` GFS, what's remaining Wim Coekaerts
2005-09-03  7:27           ` Bernd Eckenfels
2005-09-05 14:16             ` Lars Marowsky-Bree
2005-09-05 20:24               ` Bernd Eckenfels
2005-09-05 20:53                 ` Kurt Hackel
2005-09-05 23:37                 ` Joel Becker
2005-09-06  5:24                   ` Daniel Phillips
2005-09-06 12:55         ` Suparna Bhattacharya
2005-09-03  5:18       ` David Teigland
2005-09-03  6:14         ` Arjan van de Ven
2005-09-03  6:42           ` D. Hazelton
2005-09-03 10:35           ` David Teigland
2005-09-03 20:56             ` Daniel Phillips
2005-09-04 20:33         ` Pavel Machek
2005-09-04 22:18           ` Joel Becker
2005-09-05  5:54           ` Theodore Ts'o
2005-09-05  7:09             ` Mark Fasheh
2005-09-05 14:07               ` Theodore Ts'o
2005-09-05  8:27             ` real read-only [was Re: GFS, what's remaining] Pavel Machek
2005-09-05 14:03               ` Theodore Ts'o
2005-09-05 10:44           ` [Linux-cluster] Re: GFS, what's remaining Stephen C. Tweedie
2005-09-01 11:35 ` Arjan van de Ven [this message]
2005-09-02  9:44   ` David Teigland
2005-09-02 11:46     ` Jörn Engel
2005-09-03  5:28     ` Greg KH
2005-09-05  3:47       ` David Teigland
2005-09-05  8:58         ` Jörn Engel
2005-09-05  9:18           ` David Teigland
2005-09-05  5:43   ` David Teigland
2005-09-05  6:32     ` Pekka Enberg
2005-09-05  7:55       ` David Teigland
2005-09-05  8:00         ` Pekka Enberg
2005-09-10 10:11     ` Arjan van de Ven
2005-09-05  6:29   ` David Teigland
2005-09-08  5:41   ` David Teigland
2005-09-01 12:33 ` Pekka Enberg
2005-09-01 17:27 ` Daniel Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1125574523.5025.10.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-cluster@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®