From: Daniel Walker <dwalker@mvista.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com
Subject: Re: [PATCH 2.6.13] Unhandled error condition in aic79xx
Date: Thu, 01 Sep 2005 15:21:29 -0700 [thread overview]
Message-ID: <1125613289.16067.4.camel@dhcp153.mvista.com> (raw)
In-Reply-To: <20050901201029.GA10893@mipter.zuzino.mipt.ru>
On Fri, 2005-09-02 at 00:10 +0400, Alexey Dobriyan wrote:
> I see malloc(), kernel_thread() and multiple ahd_linux_alloc_target()
> above. Ditto for 7xxx patch.
It looks like it's all handled inside ahd_free() . Here's the updated
patch. Any concerns?
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
Index: linux-2.6.13/drivers/scsi/aic7xxx/aic79xx_osm.c
===================================================================
--- linux-2.6.13.orig/drivers/scsi/aic7xxx/aic79xx_osm.c 2005-08-28 23:41:01.000000000 +0000
+++ linux-2.6.13/drivers/scsi/aic7xxx/aic79xx_osm.c 2005-09-01 22:16:10.000000000 +0000
@@ -1989,6 +1989,7 @@ ahd_linux_register_host(struct ahd_softc
char *new_name;
u_long s;
u_long target;
+ int error = 0;
template->name = ahd->description;
host = scsi_host_alloc(template, sizeof(struct ahd_softc *));
@@ -2064,10 +2065,14 @@ ahd_linux_register_host(struct ahd_softc
ahd_linux_start_dv(ahd);
ahd_unlock(ahd, &s);
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0)
- scsi_add_host(host, &ahd->dev_softc->dev); /* XXX handle failure */
+ error = scsi_add_host(host, &ahd->dev_softc->dev);
+ if (error) {
+ ahd_free(ahd);
+ scsi_host_put(host);
+ return error;
+ }
scsi_scan_host(host);
-#endif
+
return (0);
}
\f\rc link
\f
aph
\x16
ÐhÝ\f)
ph
D
Ö\fc link
\x7fë\f\x11
;
\x19
h@
\x11\rc link
\x11
dw\x19
È\x7fë\f\x11
===h
\x19
h@
prev parent reply other threads:[~2005-09-01 22:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 19:38 Daniel Walker
2005-09-01 19:59 ` Jiri Slaby
2005-09-01 20:10 ` Alexey Dobriyan
2005-09-01 20:19 ` Daniel Walker
2005-09-01 22:21 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1125613289.16067.4.camel@dhcp153.mvista.com \
--to=dwalker@mvista.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®