mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rustad <mrustad@mac.com>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.15-rc5] hugetlb: make make_huge_pte global and fix coding style
Date: Fri, 9 Dec 2005 11:50:01 -0600	[thread overview]
Message-ID: <1125CAFD-A7C2-4F8A-9CBB-82D7EC7D51B8@mac.com> (raw)
In-Reply-To: <1134147943.25408.36.camel@localhost.localdomain>

On Dec 9, 2005, at 11:05 AM, Adam Litke wrote:

> On Fri, 2005-12-09 at 10:39 -0600, Mark Rustad wrote:
>> This patch makes the function make_huge_pte non-static, so it can  
>> be used
>> by drivers that want to mmap huge pages. Consequently, a prototype  
>> for the
>> function is added to hugetlb.h. Since I was looking here, I  
>> noticed some
>> coding style problems in the function and fix them with this patch.
>>
>> Signed-off-by: Mark Rustad <MRustad@mac.com>
>
> Call me crazy, but I cringe when I think of any old driver directly
> mucking with huge_ptes.  Forgive me if I am missing something, but why
> can't you just call do_mmap with a hugetlbfs file like everyone else?
> Otherwise, the CodingStyle cleanups look alright.

That would be nice, but we need multiple, contiguous huge pages.  
Actually, about 768M worth. Yeah, I guess I'll stipulate that what  
we're doing is pretty crazy, but it works well. I figure if I can  
call alloc_huge_page, I should be able to remap such a page.  
Actually, I would prefer an explicit remap call for this purpose, but  
in doing my own I found that I needed precisely the code that was  
already in make_huge_pte.

I don't have any strong feeling about whether this is accepted or  
not. I just thought that I should share a change that might be useful  
to others.

-- 
Mark Rustad, MRustad@mac.com


  reply	other threads:[~2005-12-09 17:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-09 16:39 Mark Rustad
2005-12-09 17:05 ` Adam Litke
2005-12-09 17:50   ` Mark Rustad [this message]
2005-12-09 17:16 ` Dave Hansen
2005-12-09 17:55   ` Mark Rustad
2005-12-09 18:08     ` Dave Hansen
2005-12-09 19:51       ` Mark Rustad
2005-12-09 20:37         ` Hugh Dickins
2005-12-09 21:18           ` Mark Rustad
2005-12-09 22:12             ` Hugh Dickins
2005-12-10  6:01               ` Mark Rustad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1125CAFD-A7C2-4F8A-9CBB-82D7EC7D51B8@mac.com \
    --to=mrustad@mac.com \
    --cc=agl@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®