Re: [PATCH] alpha: Use symbol assignment in SYM_END

[Thomas Huth <thuth@redhat.com>]

Am 03.11.26 um 10:09 schrieb Linus Walleij:
> Alpha uses the .set directive to select assembler options, so the
> symbol assignment emitted by the generic SYM_END macro fails to assemble.
> This breaks COMPILE_TEST builds left and right, e.g.:
> 
>    Error: junk at end of line, first unrecognized character is `,'
>    Error: .size expression for bcm6846_runner_start does not evaluate to a constant
> 
> Override SYM_END to use an ordinary symbol assignment for the calculated
> size. Preserve the symbol type, size and local size symbol while leaving
> other architectures unchanged.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202611031620.n4ptlpo7-lkp@intel.com/
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
> The generic SYM_END uses .set for symbol assignment, but Alpha interprets
> .set as an assembler mode directive. Provide an Alpha override using
> ordinary assignment.
> 
> Tested the unchanged Runner wrapper with an Alpha-targeted GNU assembler
> 2.46.1: the original header reproduces the reported errors, while the
> fixed header assembles without warnings. Symbol sizes and the embedded
> Runner bytes were checked. A full Alpha allyesconfig build was not run.
> 
> This patch was prepared with LLM assistance.
> ---
>   arch/alpha/include/asm/linkage.h | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/alpha/include/asm/linkage.h b/arch/alpha/include/asm/linkage.h
> index aa8661fa60dc..a3f0302c92d0 100644
> --- a/arch/alpha/include/asm/linkage.h
> +++ b/arch/alpha/include/asm/linkage.h
> @@ -6,4 +6,12 @@
>   #define SYSCALL_ALIAS(alias, name)					\
>   	asm ( #alias " = " #name "\n\t.globl " #alias)
>   
> +#ifdef __ASSEMBLY__

I'm currently trying to convert all __ASSEMBLY__ statements into __ASSEMBLER__:

  https://lore.kernel.org/all/20261023064908.66707-1-thuth@redhat.com/

Could you please use __ASSEMBLER__ here, too?

  Thanks,
   Thomas


> +/* Alpha uses .set for assembler options, not symbol assignments. */
> +#define SYM_END(name, sym_type)				\
> +	.type name sym_type ASM_NL			\
> +	.L__sym_size_##name = . - name ASM_NL		\
> +	.size name, .L__sym_size_##name
> +#endif
> +
>   #endif
> 
> ---
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
> change-id: 20261103-alpha-compile-efdde587115c
> 
> Best regards,
> --
> Linus Walleij <linusw@kernel.org>