From: Kars de Jong <jongk@linux-m68k.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: 8250_hp300: initialisation ordering bug
Date: Wed, 07 Sep 2005 22:17:49 +0200 [thread overview]
Message-ID: <1126124269.3968.5.camel@kars.perseus.home> (raw)
In-Reply-To: <20050904111901.A30509@flint.arm.linux.org.uk>
On zo, 2005-09-04 at 11:19 +0100, Russell King wrote:
> Hi,
>
> I've noticed that 8250_hp300 is buggy wrt the ordering of hardware
> initialisation to the visibility of devices to user space. Namely,
> 8250_hp300 does the following:
>
> ...
> serial8250_register_port() makes the port visible to userspace, so
> from that point on it could be opened. However, if it's opened
> prior to the remainder of the above completing, we will be missing
> interrupts (and what effect does "reset the DCA" have?)
>
> Surely this hardware fiddling should be completed before we register
> the port?
Yes, you are right. I am working on rewriting the driver a bit to use a
platform device for the APCI driver, I'll take your bug report into
account as well.
On a related note: can I use the "serial8250" platform driver also for
non-ISA devices (like my APCI platform device)? The comments in
drivers/serial/8250.c suggest it's for ISA devices only, but I don't see
a particular reason for not using it for my APCI devices.
Kind regards,
Kars.
next prev parent reply other threads:[~2005-09-07 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-04 10:19 Russell King
2005-09-07 20:17 ` Kars de Jong [this message]
2005-09-07 20:33 ` Russell King
2005-09-08 19:42 ` Kars de Jong
2005-09-08 19:45 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126124269.3968.5.camel@kars.perseus.home \
--to=jongk@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®